Repository navigation
π fix: preserve human and owner PRs during delegated decisions - #15219
thatguywob wants to merge 2 commits into
Conversation
Return human reviewer questions to stage 071 and prohibit adoption of human or hive owner/merger PRs, including explicit requests and re-home paths. Record blocked adoption reasons in tracker hovers and preserve relay adoption behavior. Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Hive-Run: hivecommons#15202 Hive-Plan: protect-human-pr-ownership Hive-Spec: issue-15202#human-author-adoption Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@thatguywob this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Identify relay PRs in adoption fixtures, mirror the new decision glossary, and refresh stage expectations from CI. Keep human author notifications separate from relay dispatch assertions and address authors correctly in comments and dashboard results. Allow the shared authorkind classifier in dashboard so delegated adoption uses the same ownership rules as the stage engine. Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
Decision needed (@hivecommons): #15240 already merged and closed the claimed issue, but this PR touches files the merged PR did not. Recommended: keep open until the extra changes are reviewed, or close as superseded if they are not wanted. Another option: merge anyway. Files the merged PR did not touch: This comment is edited in place by the supersession sweep; it is not duplicated. |
|
/hive decision supersede now: adopt #15219 in supersede mode, preserving the author's commits and sign-off; do not wait for the grace deadline Rationale: the contributor is offline; adoption in supersede mode keeps the work moving (#13975). Hive decided: Close this PR and open a fresh hive-authored PR with the same commits. Decided by the hive at @clubanderson's request as the owner's delegate under the owner-delegate policy (rule |
|
Closing as superseded: #15202 was fixed and merged in #15240 (v5 |
Fixes #15202
Human-authored and configured hive owner/merger PRs could be treated as offline contributor hives after Let hive decide, allowing hive to supersede the author's PR. They now retain their own PR: reviewer questions and changes return to stage 071 with an author notification, a reviewed/green/mergeable head can be admitted, and holds remain enforced.
Protect both delegated decision paths (including stage 090 and orphaned-adoption recovery), LLM action validation, and adoption/re-home execution. Explicit adoption requests cannot override the protection; terminal refusals consume the request and appear in tracker hovers even without a contributor nudge. Relay PR adoption remains available.
Validation: added table/regression coverage for routing, policy, safety rails, adoption execution, dashboard decisions, and tracker hovers; updated affected stage golden expectations and explicit relay fixtures.
gofmt -landgit diff --checkpass. Go tests/build/lint were not run locally, per AGENTS.md; CI is the test verdict.No GitHub state was changed on #15157 or #15192.
β hive: backend=codex
π Hive Agent:
contributor| SHA:d37688b43