[clubanderson]

Fixes #15277

Symptom: Activity Monitor merge toasts read ✓ # merged — title and "Open on GitHub" present, number missing (seen for the containment and never-adopt merges).

Root cause: stageTrackerMergeBanner rendered #${esc(info.number)}; info.number is a Number and esc() returns '' for any non-string. The node-harness test stubbed esc as String(s)…, which hid it.

Fix:

• Pure stageTrackerMergeBannerNumber(b): number as a string from number / pr_number / nested pr.number, else the GitHub URL (/pull/N), else the repo/pr#N key; '' when none.
• Head reads #15122 merged; with no number anywhere it reads merged — never a bare #. "Open on GitHub" is built from the same resolved number.
• Test stub esc now mirrors the page's; new cases: number only in nested pr, only in URL, empty field → head #15122 merged and the link targets the same PR; no number → no bare #.
• changelog.d/fixed-merged-toast-number.md.

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR	Title	Relation	Files
#15219	🐛 fix: preserve human and owner PRs during delegated decisions	same files	src/pkg/dashboard/static/index.html
#15186	🐛 Activity Monitor: one coherent post-decision state for Let hive decide rows; 060 reviewed in CI / Review	same files	src/pkg/dashboard/static/index.html
#15104	🐛 Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested	same files	src/pkg/dashboard/stage_tracker_cues_test.go src/pkg/dashboard/static/index.html
#15253	🐛 decision toast: issue decisions no longer read as 'approved for merge'	same files	src/pkg/dashboard/static/index.html
#15281	✨ tracker: rework pickup signal on the waiting-on chip	same files	src/pkg/dashboard/static/index.html
#15134	🐛 Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission	same files	src/pkg/dashboard/static/index.html

[hivecommons-hive]

Read the change against the tree, not just the diff. Looks correct to me.

Root cause confirmed. esc() at src/pkg/dashboard/static/index.html:39773-39774 returns '' for any non-string, and stageTrackerCelebrateMerges (index.html:19698) passes number as a Number, so #${esc(info.number)} at index.html:19816 drew a bare #. The old test stub (stage_tracker_cues_test.go:243, String(s).replace…) did not reproduce that; the new stub mirrors the page, and the new assertions (#1, nested pr.number, URL-only, empty field, no number) would fail against the old banner.

Adjacent fix is warranted. The "Recent merges" popover at index.html:19465-19470 had the same latent blank: txt.today/week/total30d/count are numeric (index.html:19401) and e.number goes through esc() unwrapped. The PR body doesn't mention this part, but it is the same mechanism and the esc(String(…)) pattern already used at index.html:36479 and 54685.

Minor, not a defect: in stageTrackerMergeBanner the recent lookup (index.html:19800) still keys on b.number, so a banner whose number lives only in pr.number/url won't pick up the ledger's title/merged_by. It still links and reads #N merged, which is what the issue asks for.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the tree, not just the diff — this looks correct to me.

• Root cause verified: esc() at src/pkg/dashboard/static/index.html:39774 returns '' for any non-string, and the live caller at index.html:19698-19699 passes number as a Number(...), so the old #${esc(info.number)} could only ever render #. The old test stub (stage_tracker_cues_test.go:243) used String(s), which is exactly why the harness never caught it; mirroring the page's esc in the stub is the right fix.
• Preview path checked: STAGE_TRACKER_CELEBRATE_TEST_KEY = 'preview/pr#0' (index.html:20309) with number: 0 — the new key fallback matches /pr#0 but Number('0') > 0 is false, so the test banner reads merged (test) with no bare #, and no URL is fabricated for it (!info.preview guard kept).
• The merged-list popover rows (index.html:19443-19449) now wrap e.number, e.repo and the counts in String(), which fixes the same class of drop in the "Recent merges" list — a small scope extension beyond the toast, but same bug, same file.

No findings.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the fix against the page, not just the diff — looks correct to me.

Root cause confirmed. esc() at src/pkg/dashboard/static/index.html:39826 is if (typeof s !== 'string') return '';, and the live caller stageTrackerCelebrateMerges (index.html:19736) passes number as a Number(...), so #${esc(info.number)} really did render # with nothing after it. The old test stub (stage_tracker_cues_test.go:243, String(s).replace…) would never have caught it; the new stub mirrors the page's behaviour, so the regression test now fails without the fix.

Fallback chain checked. stageTrackerMergeBannerNumber → number / pr_number / pr.number → /pull/N in the URL → /pr#N in the key → ''. The preview banner (index.html:20355, key preview/pr#0, number: 0) now resolves to '' and reads merged (test) instead of #0 merged (test) — a small, sensible change in the test-celebration head, worth knowing about but not a defect. The "Open on GitHub" link is now built from the same resolved number, so head and link cannot disagree.

The String(...) wrapping in the recent-merges popover (:19501–:19507) fixes the same class of bug for today/week/total30d/count, which were also numeric and would have rendered empty.

No findings. (I can't run go test on this host; the node harness assertions read correctly against the page.)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

[hivecommons-hive]

Evidence bundle `#15279262cd10` sha256:2b252835606b4e3f42129bb919780e8fe49b12622e2609013b3b47bdce09137a — download from the dashboard or `hivectl review evidence #15279`.