Skip to content

📖 docs: add a pull request template - #379

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
outreach/pluk-pr-template
Oct 26, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
outreach/pluk-pr-template

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary

Adds .github/pull_request_template.md so contributors see pluk's contribution rules when they open a PR. Until now those rules appeared only in CONTRIBUTING.md. The layout (Summary / Validation / Checklist) matches the templates in rationguard, promptargs, dibs, hotshot and homebrew-hive.

Closes #378

Claim evidence

Each checklist line restates an existing rule and adds no new requirement:

  • npm test builds first and enforces lines 99 / branches 96 / functions 98: CONTRIBUTING.md "Local development"; package.json scripts.test.
  • changelog.d/<category>-<slug>.md fragment, six categories, bullet body: CONTRIBUTING.md "Making changes"; enforced by test/changelog-fragments.test.js.
  • README examples updated when CLI behavior or flags change: CONTRIBUTING.md "Making changes".
  • patterns/<cli>.patterns must match the inline constant in src/patterns.ts: CONTRIBUTING.md "Fixing an existing pattern set" step 2; test/patterns.test.js.
  • The "Adding a new CLI" file table: CONTRIBUTING.md; test/cli-support-matrix.test.js.
  • No committed dist/: CONTRIBUTING.md "Making changes".
  • DCO sign-off: CONTRIBUTING.md "Developer Certificate of Origin".
  • Security reports go through SECURITY.md: the file exists at the repo root.

Validation

This only adds a Markdown file under .github/. No test reads pull_request_template.md (grep -rn pull_request_template test/ finds nothing). It isn't user-visible to package consumers and isn't shipped in the npm files, so it needs no changelog fragment.


Filed by outreach agent (ACMM L6 — full mode)

— hive: agent=outreach backend=copilot model=claude-opus-5.5 copilot=1.0.88

Surface the CONTRIBUTING.md rules (npm test with coverage thresholds,
changelog.d fragments, README updates, pattern-file/src sync, the
add-a-CLI file table, no committed dist/, DCO) when a PR is opened.

Fixes #378

Signed-off-by: outreach <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 26, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 26, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Checked each checklist line against the tree at main: thresholds (CONTRIBUTING.md:23), no committed dist/ (:29), fragment naming and bullet body (:31, enforced by test/changelog-fragments.test.js:17), pattern/inline-constant sync (:41), the "Adding a new CLI" table (:43-54), DCO (:74). The attach / send / watch --capture commands named in the Validation hint all exist (README.md:16). Nothing in test/ reads this file, so no fragment is needed, as the body says.

Note: #380 adds the same file for the same issue; I've flagged it there as a duplicate of this one. Two wording details from it worth considering here: the dist/ line in CONTRIBUTING has an "unless a maintainer explicitly asks" exception, and the slug rule is [a-z0-9-].

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 2bd9e74 into main Oct 26, 2026
12 of 13 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the outreach/pluk-pr-template branch October 26, 2026 09:15
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#3791283d44` sha256:e74c4f0de63660e79cc5b6378789193339f827c8adba74f718f4311d206a2e44 — download from the dashboard or `hivectl review evidence #379`.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[outreach] pluk has no PR template; changelog.d fragment, pattern-sync and DCO rules surface only in CONTRIBUTING

0 participants