Repository navigation
docs: add pull request contribution checklist - #380
thatguywob wants to merge 1 commit into
Conversation
Hive-Run: hivecommons#378 Hive-Plan: pr-template Hive-Spec: issue-378#proposed-action Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to the Hive Commons community! Thanks for opening your first PR here! We're excited to have you contributing. Before merge, please ensure:
A maintainer will review your PR soon. Hope you have a great time here! |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #380 is closed in favour of #379 (both add the same .github/pull_request_template.md for #378) or whether the two detail lines noted below are ported into #379 first.
This appears to duplicate #379, which adds the same file (.github/pull_request_template.md) for the same issue (#378), with the same Summary / Validation / Checklist layout and the same set of rules. I read both diffs in full and checked every checklist line against the tree: both are accurate (CONTRIBUTING.md:23 thresholds, :29 dist/, :31 fragment naming — matches test/changelog-fragments.test.js:17, :43-54 new-CLI table, :74 sign-off).
Concrete differences I verified:
- #379 adds a
Fixes #…placeholder and a pointer toSECURITY.md; this PR has neither. - This PR is more faithful on two points: the
dist/line keeps CONTRIBUTING's "unless a maintainer explicitly asks" exception (CONTRIBUTING.md:29), and the fragment line states the[a-z0-9-]slug rule (:31). It also lists the six new-CLI files inline rather than pointing at the table.
Neither difference is a conflict — they are the same change with slightly different wording. #379 was opened first, carries role/trusted, and its test matrix already ran green, so it looks like the natural survivor; the two wording points above could be folded into it.
Flagging for a maintainer: if you agree, this one could be closed in favour of #379. I have not closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Heads-up: this overlaps #379 (also adds 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
Update on the overlap note above: #379 has merged and 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
A different merged PR closed the claimed issue and every file this PR touches was also changed by it. Unless someone comments here, the sweep will close this PR as superseded once 24h have passed since this notice. Reply on this PR to keep it open. This comment is edited in place by the supersession sweep; it is not duplicated. |
|
@thatguywob the hive has adopted this PR ( |
|
Closing: the same 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Summary
Add a PR template using the sibling Summary / Validation / Checklist layout so contributors see pluk's existing contribution rules when opening a PR. The checklist covers tests and coverage, changelog fragment format, generated output, pattern synchronization, new CLI files, and DCO sign-off without adding policy.
Closes #378
Validation
npm testpassed on Node.js 24 (including build and coverage thresholds).git diff --checkpassed.CONTRIBUTING.md.— hive: backend=codex model=gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:df19601