Skip to content

docs: add pull request contribution checklist - #380

Closed
thatguywob wants to merge 1 commit into
hivecommons:mainfrom
thatguywob:docs/pr-template-378
Closed

thatguywob wants to merge 1 commit into
hivecommons:mainfrom
thatguywob:docs/pr-template-378

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Summary

Add a PR template using the sibling Summary / Validation / Checklist layout so contributors see pluk's existing contribution rules when opening a PR. The checklist covers tests and coverage, changelog fragment format, generated output, pattern synchronization, new CLI files, and DCO sign-off without adding policy.

Closes #378

Validation

  • npm test passed on Node.js 24 (including build and coverage thresholds).
  • git diff --check passed.
  • Compared every checklist item with CONTRIBUTING.md.

— hive: backend=codex model=gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: df19601

Hive-Run: hivecommons#378
Hive-Plan: pr-template
Hive-Spec: issue-378#proposed-action
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 26, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown

Welcome to the Hive Commons community!

Thanks for opening your first PR here! We're excited to have you contributing.

Before merge, please ensure:

  • DCO Sign-off — All commits signed with git commit -s (DCO)
  • PR Title — Starts with an emoji: ✨ feature | 🐛 bug fix | 📖 docs | 🌱 infra/tests | ⚠️ breaking

A maintainer will review your PR soon. Hope you have a great time here!

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 26, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #380 is closed in favour of #379 (both add the same .github/pull_request_template.md for #378) or whether the two detail lines noted below are ported into #379 first.

This appears to duplicate #379, which adds the same file (.github/pull_request_template.md) for the same issue (#378), with the same Summary / Validation / Checklist layout and the same set of rules. I read both diffs in full and checked every checklist line against the tree: both are accurate (CONTRIBUTING.md:23 thresholds, :29 dist/, :31 fragment naming — matches test/changelog-fragments.test.js:17, :43-54 new-CLI table, :74 sign-off).

Concrete differences I verified:

  • #379 adds a Fixes #… placeholder and a pointer to SECURITY.md; this PR has neither.
  • This PR is more faithful on two points: the dist/ line keeps CONTRIBUTING's "unless a maintainer explicitly asks" exception (CONTRIBUTING.md:29), and the fragment line states the [a-z0-9-] slug rule (:31). It also lists the six new-CLI files inline rather than pointing at the table.

Neither difference is a conflict — they are the same change with slightly different wording. #379 was opened first, carries role/trusted, and its test matrix already ran green, so it looks like the natural survivor; the two wording points above could be folded into it.

Flagging for a maintainer: if you agree, this one could be closed in favour of #379. I have not closed anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Heads-up: this overlaps #379 (also adds .github/pull_request_template.md for #378, CI green, awaiting review). Both PRs close the same issue and touch the same single file, so only one should merge — the other will conflict once the first lands.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 26, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Update on the overlap note above: #379 has merged and .github/pull_request_template.md now exists on main, and #378 is closed. That is why this branch reports a conflict — the file it adds is already there. Unless there is checklist content here that #379 lacks and should be ported as a follow-up, this PR can be closed as superseded by #379.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: pluk#378
  • Closing PR: #379

A different merged PR closed the claimed issue and every file this PR touches was also changed by it. Unless someone comments here, the sweep will close this PR as superseded once 24h have passed since this notice. Reply on this PR to keep it open.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob the hive has adopted this PR (stage/074-adopted-by-hive): CI stayed red for 2h after the nudge and the relay nudge went unanswered. The hive will rebase this branch on main and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 26, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 26, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closing: the same .github/pull_request_template.md already landed on main via #379 (merged), which closed #378. Rebasing this branch yields only a both-added conflict on that file with no remaining delta to carry. Thanks @thatguywob for the contribution.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[outreach] pluk has no PR template; changelog.d fragment, pattern-sync and DCO rules surface only in CONTRIBUTING

1 participant