Skip to content

📖 docs: add ROADMAP.md with 1.0 exit criteria and supported-CLI matrix - #409

Merged
hivecommons-hive[bot] merged 2 commits into
mainfrom
scanner/fix-408
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
mainfrom
scanner/fix-408

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary

Adds ROADMAP.md (1.0 exit criteria, supported-CLI matrix, detection-pattern contribution policy, non-goals) and links it from README and CONTRIBUTING.

Why: contributors can't tell what 1.0 requires or which CLIs are first-class, and help-wanted issues have no bar to be scoped against.

Every support level and criterion is derived from what the repo already enforces (CI gates, stryker.config.json, src/cli.ts, existing tests). Where the repo is silent (e.g. the mutation score is advisory, thresholds.break is null), the roadmap states a proposed bar rather than a promise. No dates or versions are invented.

Docs-only; no shipped code changed.

Closes #408

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — docs-only, and I checked each factual claim in ROADMAP.md against the tree at fb4ef37:

  • Coverage gate 99/95/100 → package.json test:coverage flags; run in CI at .github/workflows/ci.yml:57, with lint/build/test:workflows at ci.yml:37-46.
  • "Mutation score is advisory, thresholds.break is null" → stryker.config.json:10.
  • --dangerous mapping (claude/codex/goose; no-op for copilot/gemini) → matches README.md:86-96; rationguard itself only sets dangerouslySkipPermissions at src/cli.ts:506 and the per-CLI flag lives in pluk, consistent with the roadmap's "forwards a CLI's existing flag".
  • goose appearing only as a label in a pluk event fixture → src/cli.test.ts:1017; --cli=copilot rejected in non-watch mode → src/cli.test.ts:1217; no gemini test anywhere under src/.
  • Project-local excuses detected but never auto-sent → src/excuses.ts:11, src/cli.ts:625.

No mismatch between the body and the diff. Not approving (that is a human's call), but nothing here needs changing.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked every "enforced today" / evidence claim in ROADMAP.md against the tree at fb4ef37. All hold except one table cell.

Verified correct

  • Coverage gate 99/95/100 — package.json test:coverage; run in .github/workflows/ci.yml:57.
  • lint/build/test/test:workflows on every PR — ci.yml:37-46.
  • Mutation advisory — stryker.config.json:10 "break": null.
  • --dangerous mappings (--dangerously-skip-permissions / --full-auto / --non-interactive, no-op for copilot/gemini) — README.md:92-94, src/cli.test.ts:1584.
  • --command, --patterns-dir (watch only) — src/cli.ts:45,67,410-412.
  • Project-local excuses never auto-sent — src/excuses.ts:11-12.
  • npm provenance — .github/workflows/publish.yml:97.

One inaccuracy (low) — ROADMAP.md, supported-CLI matrix, copilot row
The Evidence cell says the only copilot-specific test is one "that --cli=copilot is rejected in a non-watch mode". The test at src/cli.test.ts:1216-1226 asserts the opposite: in the default subscribe mode --cli=copilot is accepted without the "--cli is ignored" warning (assert.doesNotMatch(..., /--cli is ignored/)), while --patterns-dir does warn. Suggested wording: "only a test that --cli=copilot is accepted without a warning in --mode=subscribe". Support level (Best-effort) is unaffected.

Docs-only; otherwise looks correct to me and consistent with #408's scope.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — docs-only, and every factual claim in ROADMAP.md matches the tree at 0cfe942:

  • Coverage gate 99/95/100 → package.json:15 (--test-coverage-lines=99 --test-coverage-branches=95 --test-coverage-functions=100).
  • Mutation score advisory, thresholds.break is null → stryker.config.json:10.
  • npm run test:workflows exists → package.json:16; it passed on this head.
  • --dangerous mappings (claude/codex/goose) and the copilot/gemini no-op → README.md:90-96, src/cli.ts:41,506.
  • --command, --cli-args, --patterns-dir flags → src/cli.ts:45,47,67.
  • ExcuseCategory in src/types.ts:15; untrusted project-local store semantics → src/excuses.ts:7-14.

No code changed; CI (build-and-test ×4, mutation ×3, verify, changelog-guard) is green. Nothing blocking from my side.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read ROADMAP.md against the tree at 0cfe942 rather than the PR body, and every factual claim checks out:

  • Coverage bar 99/95/100 — package.json:15 (--test-coverage-lines=99 --test-coverage-branches=95 --test-coverage-functions=100).
  • Mutation score advisory — stryker.config.json:10 ("break": null).
  • test:workflows script exists; the five --cli values match src/cli.ts:39.
  • --dangerous mapping (claude/codex/goose, no-op for copilot/gemini) matches the pinned @hivecommons/pluk@^0.10.0 (src/attach.ts:150-154 at v0.10.0) and README.md:92-96.
  • Untrusted project-local excuses never auto-sent — README.md:303, and the issue template excuse_pattern.yml exists.

Covers all four sections #408 asks for plus the README/CONTRIBUTING links. Looks correct to me.

One heads-up, not a defect in this PR: pluk main has since changed resolveDangerousFlag (copilot: '--allow-all-tools', gemini: '--yolo', goose dropped). When rationguard bumps pluk past 0.10, the matrix here and README.md:92-96 will both need the same update.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1

@hivecommons-hive
hivecommons-hive Bot merged commit 976e677 into main Oct 29, 2026
14 of 15 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-408 branch October 29, 2026 01:42
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#4090cfe942` sha256:ce24275154390eaa3789fc7c43784cf10c3b8d9ed130d471f2ef2ed056c64427 — download from the dashboard or `hivectl review evidence #409`.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[strategist] No ROADMAP.md: pre-1.0 (v0.14) with no stated path to 1.0 or supported-CLI matrix

0 participants