Repository navigation
[SYCL][Doc] Add std::span kernel arguments to nd_launch - #23479
Merged
uditagarwal97 merged 4 commits intoOct 20, 2026
Merged
Conversation
…and the pointer form of raw_kernel_arg
This was referenced Oct 14, 2026
uditagarwal97
requested review from
gmlueck
and
a balanced review from Copilot
October 14, 2026 15:02
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The specification is coherent, with only a non-blocking endnote formatting issue.
1 open finding
What changed in this PR
Documents C++20 span-based nd_launch arguments and portable raw pointer arguments.
Changes:
- Adds
raw_kernel_argpointer support and version 2. - Adds span-based
nd_launchoverloads, constraints, and an example.
| File | Description |
|---|---|
sycl_ext_oneapi_raw_kernel_arg.asciidoc |
Specifies pointer arguments and OpenCL support. |
sycl_ext_oneapi_enqueue_functions.asciidoc |
Specifies span overloads and usage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
See my review comments in #23481 |
This reverts commit f9f7374. A kernel defined as a named function object cannot be launched through a kernel object, so the example needs the free function kernel.
gmlueck
approved these changes
Oct 20, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec part of #22971, split out so it can be reviewed on its own:
sycl_ext_oneapi_enqueue_functionsversion 2:nd_launchoverloads taking asycl::nd_rangeand the arguments of asycl::kernelas astd::span<const raw_kernel_arg>(C++20).sycl_ext_oneapi_raw_kernel_argversion 2: apointer_argconstructor, since the byte form cannot pass a pointer portably.The other launch functions get the same overloads in #23481.