Repository navigation
[SYCL] Add std::span kernel argument overloads to the other launch functions - #23481
Open
mieshkiwrk wants to merge 8 commits into
Open
mieshkiwrk wants to merge 8 commits into
mieshkiwrk wants to merge 8 commits into
Conversation
…and the pointer form of raw_kernel_arg (cherry picked from commit f4ddb3a)
This was referenced Oct 14, 2026
gmlueck
reviewed
Oct 19, 2026
This reverts commit dba07b4. A kernel defined as a named function object cannot be launched through a kernel object, so the example needs the free function kernel.
uditagarwal97
pushed a commit
that referenced
this pull request
Oct 20, 2026
Spec part of #22971, split out so it can be reviewed on its own: - `sycl_ext_oneapi_enqueue_functions` version 2: `nd_launch` overloads taking a `sycl::nd_range` and the arguments of a `sycl::kernel` as a `std::span<const raw_kernel_arg>` (C++20). - `sycl_ext_oneapi_raw_kernel_arg` version 2: a `pointer_arg` constructor, since the byte form cannot pass a pointer portably. The other launch functions get the same overloads in #23481.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23480, as asked in the review of #22971: the same
std::span<const raw_kernel_arg>overloads forsingle_task, bothparallel_forforms andnd_launchwith alaunch_config, on a queue and a handler, with their spec. They bind through the handler, like their parameter pack overloads. They are part of version 2 of the extension, so this PR needs to land in the same release as #23479 and #23480.Depends on #23479 and #23480, whose changes it includes.