Repository navigation
[SYCL][E2E] Match big-data reduction work group sizing to runtime - #23551
Merged
Merged
Conversation
This test exercises reductions with large element types. Match the runtime’s reduGetMaxWGSize() calculation by applying the device cap before conditionally halving, so the chosen work-group size stays within the runtime limit. Assisted-By: OpenCode, GPT-6.1-Sol
uditagarwal97
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test changes match runtime sizing behavior, with no unresolved findings.
No open issues 🎉
What changed in this PR
Aligns the SYCL big-data reduction test’s work-group sizing with the runtime calculation.
Changes:
- Applies the device limit before conditionally halving the work-group size.
- Parameterizes the large vector type’s size and adds a 96-byte test case.
| File | Description |
|---|---|
| sycl/test-e2e/Reduction/reduction_big_data.cpp | Matches runtime sizing and expands element-size coverage. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test exercises reductions with large element types. Match the runtime’s reduGetMaxWGSize() calculation by applying the device cap before conditionally halving, so the chosen work-group size stays within the runtime limit.
Assisted-By: OpenCode, GPT-6.1-Sol