Skip to content

[SYCL][E2E] Match big-data reduction work group sizing to runtime #23551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
againull merged 1 commit into from
Oct 20, 2026
Merged

[SYCL][E2E] Match big-data reduction work group sizing to runtime #23551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions sycl/test-e2e/Reduction/reduction_big_data.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ size_t getSafeMaxWGSize(size_t MaxWGSize, size_t MemSize, size_t OneElemSize) {
size_t MaxNumElems = MemSize / OneElemSize;
if ((MaxNumElems & (MaxNumElems - 1)) != 0)
MaxNumElems--; // Need 1 additional element in mem if not pow of 2
return std::min(MaxNumElems / 2, MaxWGSize);
// Match the runtime's reduGetMaxWGSize() for memory-limited reductions.
size_t WGSize = std::min(MaxNumElems, MaxWGSize);
if (WGSize >= 4 && MaxNumElems < MaxWGSize * 2)
WGSize /= 2;
return WGSize;
}

template <typename Name, typename T, int Dim, class BinaryOperation>
Expand Down Expand Up @@ -66,15 +70,16 @@ int test(queue &Q, T Identity) {
return checkResults(Q, BOp, NDRange, ComputedOut, CorrectOut);
}

template <typename T> struct BigCustomVec : public CustomVec<T> {
template <typename T, size_t Size = 512>
struct BigCustomVec : public CustomVec<T> {
BigCustomVec() : CustomVec<T>() {}
BigCustomVec(T X, T Y) : CustomVec<T>(X, Y) {}
BigCustomVec(T V) : CustomVec<T>(V) {}
unsigned char OtherData[512 - sizeof(CustomVec<T>)];
unsigned char OtherData[Size - sizeof(CustomVec<T>)];
};

template <class T> struct BigCustomVecPlus {
using CV = BigCustomVec<T>;
template <class T, size_t Size = 512> struct BigCustomVecPlus {
using CV = BigCustomVec<T, Size>;
CV operator()(const CV &A, const CV &B) const {
return CV(A.X + B.X, A.Y + B.Y);
}
Expand All @@ -89,6 +94,10 @@ int main() {
using BCV = BigCustomVec<long long>;
NumErrors += test<class A2, BCV, 1, BigCustomVecPlus<long long>>(Q, BCV(0));

using CV96 = BigCustomVec<long long, 96>;
NumErrors +=
test<class A3, CV96, 1, BigCustomVecPlus<long long, 96>>(Q, CV96(0));

printFinalStatus(NumErrors);
return NumErrors;
}
Loading