Repository navigation
Conversation
Signed-off-by: jinge90 <ge.jin@intel.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The test-only changes preserve warning coverage without requiring device libraries.
No open issues 🎉
What changed in this PR
Removes unnecessary sysroot arguments from SYCL driver tests for empty target lists, which do not trigger device compilation.
Changes:
- Removes sysroot options from the
%clangand%clang_cltest commands. - Preserves the existing warning check.
| File | Description |
|---|---|
| clang/test/Driver/sycl-offload.cpp | Simplifies empty-target test commands by removing unnecessary sysroots. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests with empty fsycl-targets just emits warning and will not trigger device compilation, so devicelib is not involved, we can safely remove the sysroot.