Skip to content

[SYCL][Driver][Test] Remove sysroot for test lines with empty targets #23556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jinge90 wants to merge 1 commit into from
Closed

[SYCL][Driver][Test] Remove sysroot for test lines with empty targets #23556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/test/Driver/sycl-offload.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
/// ###########################################################################

/// Check warning for empty -fsycl-targets
// RUN: %clang -### -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL -fsycl-targets= %s 2>&1 \
// RUN: %clang -### -fsycl --offload-new-driver -fsycl-targets= %s 2>&1 \

@mdtoguchi mdtoguchi Oct 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to work as there is no device compilation that occurs when -fsycl-targets= is passed on the command line. The driver diagnostic states that the argument is unused, which implies that -fsycl --offload-new-driver <file> is performed which should do a device compilation. As it's not doing a device compile, I interpret that as a bug in the driver.

@jinge90 jinge90 Oct 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mdtoguchi
You are right, we will still need to locate the dummy devicelibs once the bug is fixed, will close this PR and file a bug ticket for this issue.

// RUN: | FileCheck -check-prefix=CHK-EMPTY-SYCLTARGETS %s
// RUN: %clang_cl -### -fsycl --offload-new-driver /clang:--sysroot=%S/Inputs/SYCL -fsycl-targets= %s 2>&1 \
// RUN: %clang_cl -### -fsycl --offload-new-driver -fsycl-targets= %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHK-EMPTY-SYCLTARGETS %s
// CHK-EMPTY-SYCLTARGETS: warning: joined argument expects additional value: '-fsycl-targets='

Expand Down
Loading