Skip to content

fix(googlechat): keep completed answers after progress - #16

Merged
jai merged 1 commit into
fix/googlechat-maintained-main-2026-10-15from
patch/linus-googlechat-2026-11-08
Nov 9, 2026
Merged

jai merged 1 commit into
fix/googlechat-maintained-main-2026-10-15from
patch/linus-googlechat-2026-11-08

Conversation

@jai

@jai jai commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

What Problem This Solves

Google Chat places completed answers above later progress messages when OpenClaw edits its original typing message.

User Impact

Completed answers arrive after progress in the source conversation. One temporary activity message disappears after confirmed delivery. Partial or uncertain sends retain feedback.

Why This Change Was Made

The activity message has a separate lifetime from the final answer. The overlay also restores delivery-only DM and queued thread context, plus the existing optional room-session setting. The deployed version and dependency lock remain unchanged.

Evidence

Four new regressions failed before the fix. All 101 focused tests passed, with 42 affected cases rerun after the lifecycle typing correction. Production extension typechecking and type-aware lint passed. Independent AI review found no blocking findings. The restored sessionThread setting adds two generated configuration entries, root and account, changing the documented budget from 4031 to 4033.

The Linus image passed Linux import closure and native-addon checks. Its deployed gateway returned LINUS_CHAT_PATCH_OK through Codex, Google Chat probes passed, and all 32 prior session IDs remained intact. Post-deployment rendering in the Google Chat app awaits a natural reply. Executor test skills generate the separate Skill check markers.

Deployment pin and rollback documentation are in https://github.com/EWA-Services/openclaw-infrastructure/pull/909. Rollout tracking: https://linear.app/finnapp/issue/ENG-3461/keep-openclaw-chat-answers-in-order-and-align-fleet-patches

Append final answers through durable delivery while retaining one temporary activity message. Carry source thread context independently of sessions, restore opt-in room sessions, and settle queued or explicit sends only after confirmed source delivery.
@jai jai added agent-ignore Human actively working this PR; autonomous agents skip and removed agent-ignore Human actively working this PR; autonomous agents skip labels Nov 8, 2026
@jai
jai marked this pull request as ready for review November 9, 2026 12:24
@jai
jai merged commit f594f87 into fix/googlechat-maintained-main-2026-10-15 Nov 9, 2026
91 of 100 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T12:29:30.862056Z 1c0088c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

jai added a commit that referenced this pull request Nov 9, 2026
# Conflicts:
#	FORK_PATCHES.md
#	extensions/googlechat/src/monitor.test.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c0088cc29

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +409 to +412
await activity?.stop();
if (hasVisibleAnswer && !deliveryFailed) {
await settleStatus();
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove activity after silent deferred turns settle

When a turn is deferred and later settles without a visible answer—for example after NO_REPLY, suppression, cancellation, or queue abandonment—hasVisibleAnswer remains false, so this callback never invokes settleStatus; the earlier finally block also skips cleanup because the lifecycle had not settled yet. Since activity.stop() merely closes updates, the Google Chat typing/activity message remains visible indefinitely even though no work is active. Settled no-delivery outcomes should delete the placeholder unless delivery actually failed or remains uncertain.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant