Skip to content

fix(googlechat): keep shared gateway final answers after progress - #17

Merged
jai merged 1 commit into
maintain/googlechat-patch-stack-2026-10-17from
patch/shared-googlechat-2026-11-08
Nov 9, 2026
Merged

jai merged 1 commit into
maintain/googlechat-patch-stack-2026-10-17from
patch/shared-googlechat-2026-11-08

Conversation

@jai

@jai jai commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

What Problem This Solves

Google Chat final answers can appear above later progress or lose the source thread on the FINN shared gateway.

User Impact

Final answers appear after progress in their original thread. Activity remains visible until delivery is confirmed.

Why This Change Was Made

Ports the Linus delivery fix onto the shared gateway’s existing OpenClaw 2026.10.4 base, retaining its eight earlier patches and current session identities. No dependency, schema, model, credential or config changes.

Evidence

155 focused tests, production extension typecheck, type-aware lint and independent AI review passed. Full build passed. Deployed after idle: 329 prior session IDs and the config hash preserved, all nine Chat probes passed, and isolated Sparky/Zola Codex turns returned the expected markers with delivery disabled. The complete Linux graph and managed Exa host peer were checked. Natural Chat rendering remains to be observed.

Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).

@jai
jai marked this pull request as ready for review November 9, 2026 12:24
@jai
jai merged commit d1fd741 into maintain/googlechat-patch-stack-2026-10-17 Nov 9, 2026
90 of 96 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T12:30:40.693861Z 5b5c6ff Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

jai added a commit that referenced this pull request Nov 9, 2026
# Conflicts:
#	FORK_PATCHES.md
#	extensions/googlechat/src/monitor.test.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b5c6ff859

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +534 to +536
onObservedReplyDelivery: async () => {
hasVisibleAnswer = true;
await settleStatus();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate cleanup on confirmed terminal queued delivery

When a Google Chat turn is deferred, sendFollowupPayloads invokes its observed-delivery callback for every routed payload with result.delivered, including tool/block progress and partially delivered finals where result.ok is false; the production follow-up wrapper forwards that call to this new hook. Consequently, the first queued progress update or partial final sets hasVisibleAnswer and runs settleStatus(), deleting the activity message before a terminal answer is confirmed, despite the stricter terminal check later in followup-delivery.ts. Only settle from a signal gated to a successful terminal source delivery.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant