Repository navigation
fix(googlechat): keep Chat markup in shared gateway answers - #19
Merged
jai merged 5 commits intoNov 9, 2026
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jai
changed the base branch from
patch/shared-googlechat-2026-11-08
to
maintain/googlechat-patch-stack-2026-10-17
November 9, 2026 12:24
# Conflicts: # FORK_PATCHES.md # extensions/googlechat/src/monitor.test.ts
jai
merged commit Nov 9, 2026
70323de
into
maintain/googlechat-patch-stack-2026-10-17
27 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Google Chat showed agent answers as one paragraph with literal
<url|label>links. Chat apps created after 2026-10-16 read message text as Markdown by default, but the formatter writes Chat markup.User Impact
Answers keep their line breaks, and links show as clickable labels again.
Why This Change Was Made
Message creates and edits now send
markupSyntax: MARKUP_SYNTAX_CHATwith their text, which matches what the formatter produces. Cards-only messages are unchanged. The progress-then-final ordering from #17 is unchanged. Also fixes onecurlylint error in a #17 test.Evidence
A new test sends a threaded final answer through the real durable delivery path and checks the request body. It failed before the fix and passes now. 307 focused tests, the production extension typecheck, type-aware lint and an independent AI review passed. Deployed to the FINN shared gateway on 9 November after all agents were idle; all nine Chat probes passed, and a real Iris reply showed three lines with three labelled links. Runtime pin: openclaw-infrastructure #911 (merged).
Stacked on #17. Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).