Skip to content

fix(googlechat): keep Chat markup in shared gateway answers - #19

Merged
jai merged 5 commits into
maintain/googlechat-patch-stack-2026-10-17from
patch/shared-googlechat-format-2026-11-09
Nov 9, 2026
Merged

jai merged 5 commits into
maintain/googlechat-patch-stack-2026-10-17from
patch/shared-googlechat-format-2026-11-09

Conversation

@jai

@jai jai commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

What Problem This Solves

Google Chat showed agent answers as one paragraph with literal <url|label> links. Chat apps created after 2026-10-16 read message text as Markdown by default, but the formatter writes Chat markup.

User Impact

Answers keep their line breaks, and links show as clickable labels again.

Why This Change Was Made

Message creates and edits now send markupSyntax: MARKUP_SYNTAX_CHAT with their text, which matches what the formatter produces. Cards-only messages are unchanged. The progress-then-final ordering from #17 is unchanged. Also fixes one curly lint error in a #17 test.

Evidence

A new test sends a threaded final answer through the real durable delivery path and checks the request body. It failed before the fix and passes now. 307 focused tests, the production extension typecheck, type-aware lint and an independent AI review passed. Deployed to the FINN shared gateway on 9 November after all agents were idle; all nine Chat probes passed, and a real Iris reply showed three lines with three labelled links. Runtime pin: openclaw-infrastructure #911 (merged).

Stacked on #17. Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T05:09:03.900990Z 6b6f5a7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jai
jai changed the base branch from patch/shared-googlechat-2026-11-08 to maintain/googlechat-patch-stack-2026-10-17 November 9, 2026 12:24
# Conflicts:
#	FORK_PATCHES.md
#	extensions/googlechat/src/monitor.test.ts
@jai
jai merged commit 70323de into maintain/googlechat-patch-stack-2026-10-17 Nov 9, 2026
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant