Skip to content

fix(googlechat): stop duplicate answers after message-tool sends - #22

Merged
jai merged 3 commits into
fix/googlechat-maintained-main-2026-10-15from
fix/googlechat-message-tool-final-receipt-2026-11-10
Nov 9, 2026
Merged

jai merged 3 commits into
fix/googlechat-maintained-main-2026-10-15from
fix/googlechat-message-tool-final-receipt-2026-11-10

Conversation

@jai

@jai jai commented Nov 9, 2026

Copy link
Copy Markdown
Owner

What Problem This Solves

SysOps posted the same answer twice in Google Chat. The model sent its answer with the message tool (final: true), and the run then started settled-turn finalization, which posted a second copy.

User Impact

An answer sent through the message tool appears once.

Why This Change Was Made

The Google Chat send action returned no delivery receipt. The send inherits the source thread through replyTo, so its arguments name no thread. Without a delivered thread, source-reply matching (resolveSourceReplyThreadPlacement in src/infra/outbound/source-reply-mirror.ts) classifies the placement as unknown and does not mark the source reply delivered. The run then saw no final answer and ran isolated finalization.

The action now returns a receipt with the delivered message names and thread, as the Google Chat outbound adapter already does.

Evidence

SysOps run f450399f (2026-11-09 18:21 +07): transcript shows a successful message send to spaces/AAQAlPR3m3s/threads/0xv5xHSzZAs, then settled post-tool turn lacked a final answer, then a finalizer answer with the same text.

New action regression failed before the fix. A source-reply classification case with the real Google Chat payload is delivered with the receipt and not delivered without it. 301 Google Chat and source-reply tests, extension typecheck and lint passed.

Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).

A message-tool send that inherits the source thread returned no receipt, so source-reply completion could not prove the answer landed in the current thread. The run then started settled-turn finalization and posted the same answer twice.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-09T23:36:32.015181Z
We couldn’t complete this review. Comment @codex review to try again.
eef0abe PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@jai
jai merged commit 8063a28 into fix/googlechat-maintained-main-2026-10-15 Nov 9, 2026
223 of 234 checks passed
jai added a commit that referenced this pull request Nov 10, 2026
…ge-tool sends (#23)

Port of #22. A message-tool send that inherits the source thread returned no receipt, so source-reply completion could not prove the answer landed in the current thread, and settled-turn finalization posted it again. Receipts list only sent messages and Chat's confirmed thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant