Repository navigation
fix(googlechat): stop duplicate answers after message-tool sends - #22
Merged
jai merged 3 commits intoNov 9, 2026
Conversation
A message-tool send that inherits the source thread returned no receipt, so source-reply completion could not prove the answer landed in the current thread. The run then started settled-turn finalization and posted the same answer twice.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
jai
merged commit Nov 9, 2026
8063a28
into
fix/googlechat-maintained-main-2026-10-15
223 of 234 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
SysOps posted the same answer twice in Google Chat. The model sent its answer with the
messagetool (final: true), and the run then started settled-turn finalization, which posted a second copy.User Impact
An answer sent through the message tool appears once.
Why This Change Was Made
The Google Chat
sendaction returned no delivery receipt. The send inherits the source thread throughreplyTo, so its arguments name no thread. Without a delivered thread, source-reply matching (resolveSourceReplyThreadPlacementinsrc/infra/outbound/source-reply-mirror.ts) classifies the placement as unknown and does not mark the source reply delivered. The run then saw no final answer and ran isolated finalization.The action now returns a receipt with the delivered message names and thread, as the Google Chat outbound adapter already does.
Evidence
SysOps run
f450399f(2026-11-09 18:21 +07): transcript shows a successfulmessagesend tospaces/AAQAlPR3m3s/threads/0xv5xHSzZAs, thensettled post-tool turn lacked a final answer, then a finalizer answer with the same text.New action regression failed before the fix. A source-reply classification case with the real Google Chat payload is delivered with the receipt and not delivered without it. 301 Google Chat and source-reply tests, extension typecheck and lint passed.
Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).