Skip to content

fix(googlechat): fold message-tool progress into the activity message - #29

Merged
jai merged 3 commits into
maintain/googlechat-patch-stack-2026-10-17from
fix/googlechat-fold-progress-sends
Nov 11, 2026
Merged

jai merged 3 commits into
maintain/googlechat-patch-stack-2026-10-17from
fix/googlechat-fold-progress-sends

Conversation

@jai

@jai jai commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Progress updates an agent sends with message(action=send, final=false) now edit the turn's activity message instead of posting standalone messages.

Why: in the 2026-11-10 comms test, 8 agents left 1–3 progress posts per turn that were never removed (for example Iris in spaces/AAQAD7VAgxU, thread mUjcUVbwfSw). Automatic commentary already edited the activity message, but message-tool progress went through the Google Chat send action and posted a new message.

Change (layer 12):

  • Core passes the host-owned sourceReplyFinal to channel message actions, on both the gateway and local paths.
  • The Google Chat monitor registers a turn's open activity message by account, space and thread.
  • A progress send to that same placement edits the activity message and returns its receipt. The activity message, and the progress in it, is removed when the turn settles.
  • Final sends, sends to another thread, and sends after the activity closes still post normally.

Checks: Google Chat tests 279/279, tsgo core and extensions clean, git diff --check clean.

A `message(action=send, final=false)` progress update went through the
Google Chat send action and posted a standalone message. Only automatic
commentary edited the activity message, so these posts stayed in the
thread after the turn's activity message was removed.

Core now passes the host-owned `sourceReplyFinal` to channel message
actions. While a turn's activity message is open, the monitor registers
it by account, space and thread. A progress send to that same placement
edits the activity message and returns its receipt; it is removed with
the activity message when the turn settles. Final sends, sends to other
threads, and sends after the activity closes still post normally.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T03:17:14.050912Z
We couldn’t complete this review. Comment @codex review to try again.
82c6075 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

jai added 2 commits November 11, 2026 10:24
…read

Match only the thread Chat placed the activity message in and the session that owns the turn, run the send's handoff and dispatch guards before the edit, and report an edit skipped after the activity closed as not delivered so the send posts normally.
jai added a commit that referenced this pull request Nov 11, 2026
…y message

Port of the shared-stack fix (#29) onto the Jai Work overlay.
A `message(action=send, final=false)` progress update to the turn's own
space, delivered thread and session now edits the typing placeholder
instead of posting a standalone message. The placeholder is replaced by
the first normal answer or removed when the turn settles. Status-label
and progress edits share one serialized write queue.
@jai
jai merged commit 44136e8 into maintain/googlechat-patch-stack-2026-10-17 Nov 11, 2026
252 of 267 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant