Repository navigation
fix(googlechat): fold message-tool progress into the activity message - #29
Merged
jai merged 3 commits intoNov 11, 2026
Conversation
A `message(action=send, final=false)` progress update went through the Google Chat send action and posted a standalone message. Only automatic commentary edited the activity message, so these posts stayed in the thread after the turn's activity message was removed. Core now passes the host-owned `sourceReplyFinal` to channel message actions. While a turn's activity message is open, the monitor registers it by account, space and thread. A progress send to that same placement edits the activity message and returns its receipt; it is removed with the activity message when the turn settles. Final sends, sends to other threads, and sends after the activity closes still post normally.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…read Match only the thread Chat placed the activity message in and the session that owns the turn, run the send's handoff and dispatch guards before the edit, and report an edit skipped after the activity closed as not delivered so the send posts normally.
jai
added a commit
that referenced
this pull request
Nov 11, 2026
…y message Port of the shared-stack fix (#29) onto the Jai Work overlay. A `message(action=send, final=false)` progress update to the turn's own space, delivered thread and session now edits the typing placeholder instead of posting a standalone message. The placeholder is replaced by the first normal answer or removed when the turn settles. Status-label and progress edits share one serialized write queue.
jai
merged commit Nov 11, 2026
44136e8
into
maintain/googlechat-patch-stack-2026-10-17
252 of 267 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress updates an agent sends with
message(action=send, final=false)now edit the turn's activity message instead of posting standalone messages.Why: in the 2026-11-10 comms test, 8 agents left 1–3 progress posts per turn that were never removed (for example Iris in
spaces/AAQAD7VAgxU, threadmUjcUVbwfSw). Automatic commentary already edited the activity message, but message-tool progress went through the Google Chat send action and posted a new message.Change (layer 12):
sourceReplyFinalto channel message actions, on both the gateway and local paths.Checks: Google Chat tests 279/279,
tsgocore and extensions clean,git diff --checkclean.