Repository navigation
fix(googlechat): keep folded progress when a turn ends without an answer - #33
Conversation
When an agent folds a progress update into the activity message and then yields to a subagent, the turn settles with no answer and the monitor deleted the activity message, leaving no visible trace. Keep it as the last folded progress text unless a separate answer was posted in that placement by monitor delivery or a message-tool send.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a0bee0f1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| const placeholder = typingMessage; | ||
| typingMessage = undefined; | ||
| if (placeholder && foldedProgressText && !answerPosted) { |
There was a problem hiding this comment.
Mark observed deliveries as separately posted answers
When a final source reply is confirmed through onObservedReplyDelivery—for example, a shared Gateway delivery—that callback sets only hasVisibleAnswer, not answerPosted. If progress was folded earlier, this condition remains true, so settlement restores the activity and returns instead of deleting it, leaving stale progress beside the confirmed answer. Set the separate-answer flag for observed delivery as well.
Useful? React with 👍 / 👎.
| accountId: account.accountId, | ||
| spaceId: space, | ||
| threadName: deliveredThread, | ||
| sessionKey, | ||
| })?.noteSeparatePost?.(); |
There was a problem hiding this comment.
Mark accepted chunks before throwing partial delivery
When a long message-tool answer is chunked and a later sendGoogleChatMessage call fails, the handler throws a partial-delivery error after earlier chunks are already visible. This notification runs only after the whole loop succeeds, so the activity is never marked; settlement then preserves folded progress alongside the partial answer. Notify the matching activity before throwing whenever acceptedText is nonempty.
Useful? React with 👍 / 👎.
|
Codex review (CLI): applied the one finding — automatic commentary/status notices folded into the activity message are now kept on a silent turn too (test added). 307/307 Google Chat tests, extension tsgo clean. |
Regression from layer 12 (#29/#31): Cosmo folded a progress update into the activity message, then yielded to a subagent. The turn settled with no answer and the activity message was deleted, so the DM showed nothing.
Now the activity message is kept, showing the last folded progress, unless a separate answer was posted in that placement (monitor delivery or a message-tool send). Tests: Google Chat 306/306, including both cases; extension
tsgoclean.