Skip to content

develop => main - #285

Merged
ialarmedalien merged 162 commits into
mainfrom
develop
Oct 20, 2026
Merged

ialarmedalien merged 162 commits into
mainfrom
develop

Conversation

@ialarmedalien

Copy link
Copy Markdown
Collaborator

No description provided.

ialarmedalien and others added 30 commits June 22, 2026 10:08
Rename functions/variables to remove references to delta lake format
* allow bucket-only ls with s3 cli

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* add s3 cli helper tests

* and changes missing from last commit

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Update src/cdm_data_loaders/utils/s3.py

Co-authored-by: i alarmed alien <ialarmedalien@users.noreply.github.com>

* address review comments

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: i alarmed alien <ialarmedalien@users.noreply.github.com>
Use berdl_notebook_utils on spark_notebook image
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* add ncbi promote cli and update docs

* remove notebook; update tests

* clear notebook output

* add promote pipeline tests

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* address review comments

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* add xsv-validator to Dockerfile

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* workaround for potential ceph service race condition

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Moving the settings objects to cdm_data_loaders.core

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

* fixing missing import

* another incorrect import

* Another infernal import error

* remove -l alias; use generate_aliases where possible

* minor rearrangement

* fix uniref alias

---------

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* add xsv module

* formatting

* Potential fix for pull request finding 'Unused global variable'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix copilot mod

* exclude xsv tests from spark test action

* use pydantic for validation

* formatting

---------

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* draft pdb manifest pipeline and tests

* add tests; fix bug in transfer manifest logic

* write walkthrough doc and debug

* clean up paths

* add missing tests

* address reviewer comments

* create holdings file parser

* remove unused variables

* increase trivy timeout
* Move utils.s3 to utils.file_transfer.s3.*

* convert new modules to using relocated s3 functions
* Move cli commands to their own module

* Removing tests from old module, cleaning up some cruft

* remove the cli functions... duh
* Updating checksum module to provide a generic interface to calculate checksums

* Updated version of tests
* Adding in missing tests and an interface to upload_fileobj

* missing moon
* Minor reorg:
- function renaming
- use the same mock s3 client for tests where AWS is mocked
- centralise values in a DEFAULT config
* Adding new xsv validator mode plus support, with tests.

* adding vital fixtures

* adding qsv check cmd; updating dockerfile with new qsv version

* fix failing tests
ialarmedalien and others added 26 commits October 17, 2026 12:38
Convert the xsv import pipeline to using the filesystem resource
* Introduce PipelineCli, run_cli cli_args, and non-fatal _save_load_info

* Fix failing tests and apply ruff lint/format fixes

* Restore stream_to_s3 re-export in streamer.py
update dockerfile and entry point
Adding extra codecov coverage uploads
Removing commented-out code
Adding pipeline report file to output
Bump version from 0.1.10 to 0.1.11
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.77638% with 755 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.04%. Comparing base (c7d3ebd) to head (2ec93fb).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/cdm_data_loaders/pipelines/pdb_manifest.py 0.00% 124 Missing ⚠️
src/cdm_data_loaders/pipelines/core.py 32.07% 72 Missing ⚠️
.../jsonlines/extract_jsonschema_validate_pipeline.py 0.00% 67 Missing ⚠️
...rc/cdm_data_loaders/pipelines/xml2db/compaction.py 0.00% 59 Missing ⚠️
src/cdm_data_loaders/pipelines/xsv/pipeline.py 0.00% 59 Missing ⚠️
src/cdm_data_loaders/pipelines/jsonlines/base.py 0.00% 57 Missing ⚠️
src/cdm_data_loaders/pipelines/xsv/settings.py 0.00% 39 Missing ⚠️
src/cdm_data_loaders/pipelines/xml2db/pipeline.py 0.00% 37 Missing ⚠️
src/cdm_data_loaders/pipelines/all_the_bacteria.py 0.00% 34 Missing ⚠️
...es/jsonlines/extract_pydantic_validate_pipeline.py 0.00% 34 Missing ⚠️
... and 16 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #285       +/-   ##
===========================================
+ Coverage   66.91%   80.04%   +13.12%     
===========================================
  Files          72       90       +18     
  Lines        4413     6560     +2147     
===========================================
+ Hits         2953     5251     +2298     
+ Misses       1460     1309      -151     
Files with missing lines Coverage Δ
src/cdm_data_loaders/converters/core/errors.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/extensions.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/guards.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/io.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/ir.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/ir_values.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/metadata.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/paths.py 100.00% <100.00%> (ø)
...c/cdm_data_loaders/converters/dlt_to_jsonschema.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/emitters/dlt.py 100.00% <100.00%> (ø)
... and 74 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c9c1a...2ec93fb. Read the comment docs.

@ialarmedalien
ialarmedalien merged commit b87125b into main Oct 20, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants