Skip to content

Workflow run tests - #291

Merged
ialarmedalien merged 6 commits into
developfrom
workflow_run_tests
Oct 20, 2026
Merged

ialarmedalien merged 6 commits into
developfrom
workflow_run_tests

Conversation

@ialarmedalien

Copy link
Copy Markdown
Collaborator

Reorg and refactor of pipeline tests.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
5304 1 5303 211
View the top 1 failed test(s) by shortest run time
tests/cdm_data_loaders/pipelines/jsonlines/integration/test_jsonlines_reference_tests.py::test_jsonlines_pass_no_data_lost_across_worker_configs[jsonlines_pydantic-jsonl-extract_3-normalize_2-load_2]
Stack Traces | 13.7s run time
run_reference_pipeline = <function run_reference_pipeline.<locals>._factory at 0x7f2248e52ca0>
sorted_reference_entities = ['{"accession": "GCA_000003115.1", "assembly_info": {"assembly_level": "Chromosome", "assembly_name": "catChrV17e", "a...ype 5", "tax_id": 2025339}, "paired_accession": "GCF_002271065.1", "source_database": "SOURCE_DATABASE_GENBANK"}', ...]
extract_workers = 3, normalize_workers = 2, load_workers = 2
loader_file_format = <LoaderFileFormatEnum.JSONL: 'jsonl'>

    @pytest.mark.parametrize(
        ("extract_workers", "normalize_workers", "load_workers"),
        WORKER_CONFIGS,
        ids=[f"extract_{extract}-normalize_{normalize}-load_{load}" for extract, normalize, load in WORKER_CONFIGS],
    )
    @pytest.mark.parametrize("loader_file_format", LOADER_FILE_FORMATS, ids=str)
    def test_jsonlines_pass_no_data_lost_across_worker_configs(
        *,
        run_reference_pipeline: Callable[..., Any],
        sorted_reference_entities: list[str],
        extract_workers: int,
        normalize_workers: int,
        load_workers: int,
        loader_file_format: str,
    ) -> None:
        """No data is lost regardless of how the job is split across extract/normalize/load workers."""
        load_info_and_dir = {}
        with dlt.config.values(
            {
                "extract.workers": extract_workers,
                "normalize.workers": normalize_workers,
                "load.workers": load_workers,
            }
        ):
>           load_info_and_dir["chunk_4"] = run_and_read(
                run_reference_pipeline, "chunk_4", loader_file_format=loader_file_format
            )

.../jsonlines/integration/test_jsonlines_reference_tests.py:219: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

run_pipeline = <function run_reference_pipeline.<locals>._factory at 0x7f2248e52ca0>
chunk_dir = 'chunk_4'
overrides = {'loader_file_format': <LoaderFileFormatEnum.JSONL: 'jsonl'>}

    def run_and_read(
        run_pipeline: Any,
        chunk_dir: str,
        **overrides: Any,
    ) -> tuple[LoadInfo, Path]:
        """Run the pipeline on a chunk dir and return the run result with its tables."""
        (load_info, output_dir) = run_pipeline(chunk_dir, **overrides)
>       assert load_info is not None
               ^^^^^^^^^^^^^^^^^^^^^
E       AssertionError

.../cdm_data_loaders/pipelines/helpers.py:267: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@ialarmedalien
ialarmedalien merged commit 673db32 into develop Oct 20, 2026
18 of 21 checks passed
@ialarmedalien
ialarmedalien deleted the workflow_run_tests branch October 20, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant