Skip to content

Refactor: remove lots of repeated rebar - #296

Merged
ialarmedalien merged 4 commits into
developfrom
refactor
Oct 22, 2026
Merged

ialarmedalien merged 4 commits into
developfrom
refactor

Conversation

@ialarmedalien

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.75728% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (e35a843) to head (e6ca398).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/cdm_data_loaders/pipelines/jsonlines/base.py 0.00% 10 Missing ⚠️
src/cdm_data_loaders/pipelines/core.py 47.05% 9 Missing ⚠️
...rc/cdm_data_loaders/pipelines/ncbi_ftp_download.py 47.05% 9 Missing ⚠️
src/cdm_data_loaders/pipelines/xsv/pipeline.py 0.00% 4 Missing ⚠️
src/cdm_data_loaders/pipelines/all_the_bacteria.py 0.00% 3 Missing ⚠️
src/cdm_data_loaders/pipelines/xml2db/pipeline.py 0.00% 3 Missing ⚠️
...c/cdm_data_loaders/pipelines/xmltodict/pipeline.py 0.00% 3 Missing ⚠️
...dm_data_loaders/pipelines/xmltopyarrow/pipeline.py 0.00% 3 Missing ⚠️
...ta_loaders/pipelines/jsonlines/extract_pipeline.py 0.00% 2 Missing ⚠️
src/cdm_data_loaders/pipelines/pdb_manifest.py 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #296      +/-   ##
===========================================
+ Coverage    80.58%   81.17%   +0.58%     
===========================================
  Files           96       96              
  Lines         7148     7101      -47     
===========================================
+ Hits          5760     5764       +4     
+ Misses        1388     1337      -51     
Files with missing lines Coverage Δ
src/cdm_data_loaders/core/fields.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/core/settings.py 100.00% <100.00%> (ø)
...c/cdm_data_loaders/pipelines/jsonlines/settings.py 90.32% <ø> (-0.31%) ⬇️
src/cdm_data_loaders/pipelines/ncbi_ftp_promote.py 0.00% <ø> (ø)
src/cdm_data_loaders/pipelines/xml2db/settings.py 100.00% <100.00%> (ø)
...c/cdm_data_loaders/pipelines/xmltodict/settings.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/readers/jsonlines.py 100.00% <100.00%> (+2.17%) ⬆️
...rs/readers/jsonschema_xsv/xsv_validator/helpers.py 100.00% <100.00%> (ø)
...oaders/readers/jsonschema_xsv/xsv_validator/qsv.py 89.07% <100.00%> (+0.47%) ⬆️
...aders/jsonschema_xsv/xsv_validator/schema_utils.py 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35a843...e6ca398. Read the comment docs.

@ialarmedalien
ialarmedalien merged commit 8166714 into develop Oct 22, 2026
19 of 21 checks passed
@ialarmedalien
ialarmedalien deleted the refactor branch October 22, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant