Skip to content

Add brainstorm threads: continue/complete turns with a fixed budget - #30

Merged
leonlee merged 2 commits into
mainfrom
feature/brainstorm
Nov 6, 2026
Merged

leonlee merged 2 commits into
mainfrom
feature/brainstorm

Conversation

@leonlee

@leonlee leonlee commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Step 3 of the beyond-review plan, after pair reviewer (#28) and spec review (#29). No release until the whole set is in.

What

  • pair send request --brainstorm opens a thread for ideas before there's a design. The reviewer replies --verdict continue|complete with options, trade-offs and questions; the author answers with pair send response.
  • The request stores budget:, the PAIR_MAX_ROUNDS value when it opened, so the agents' shells can't disagree on it. On the last round, pair refuses continue, and the closing reply lists the options, a recommendation and the open decisions. Brainstorms never escalate; they archive as completed.
  • Brainstorm messages use their own statuses (brainstorming, completed), so pair 0.7.4 and earlier reject the request as a corrupt message instead of reviewing it as code. Both agents need 0.8.0.
  • Auto mode gives a brainstorm round its own managed prompt: one continue|complete contribution, read-only, no further wait. The author prompt and the agents' instructions describe the brainstorm flow.

Review

  • Codex approved the design in thread 2026-11-06T05-19-31-945Z-da0bac, after one finding: store the budget instead of reading the environment.
  • Codex approved the implementation in thread 2026-11-06T05-28-02-657Z-4ed4f7. It also built 0.7.4 and confirmed it rejects an active brainstorm on wait, status, send review and send request.

Tests

npm test: 119 pass, 4 of them new:

  • an e2e brainstorm whose stored budget stays fixed when PAIR_MAX_ROUNDS changes;
  • verdict and status checks across the two thread kinds, including corrupt messages;
  • a brainstorm through managed auto rounds, once with each agent as author.

🤖 Generated with Claude Code

https://claude.ai/code/session_012Y3kg5hjT2zSZM9qUEEinM

leonlee and others added 2 commits November 6, 2026 14:35
pair send request --brainstorm opens a thread for ideas before there's a
design. The reviewer replies --verdict continue|complete, and the author
answers with pair send response. The request stores budget:, the
PAIR_MAX_ROUNDS in effect when it opened, so the agents' shells can't
disagree on it; on the last round continue is refused, and the closing
reply lists the options, a recommendation and the open decisions.

Brainstorm messages use their own statuses (brainstorming, completed),
so pair 0.7.4 and earlier reject the request as corrupt instead of
reviewing it as code. Completed threads archive as -completed. Auto mode
gives a brainstorm round its own managed prompt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Y3kg5hjT2zSZM9qUEEinM
…state table

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012Y3kg5hjT2zSZM9qUEEinM
@leonlee
leonlee merged commit 38d4d52 into main Nov 6, 2026
2 checks passed
@leonlee
leonlee deleted the feature/brainstorm branch November 6, 2026 05:47
@leonlee leonlee mentioned this pull request Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant