Repository navigation
[17.0-stable] evetest: port scans; fix the exposure they found on EVE and EVE-k - #6753
Merged
rene merged 4 commits intoOct 12, 2026
Merged
Conversation
sshd in the debug container ran with Alpine's defaults, which offer password and keyboard-interactive authentication to anyone who connects. No account has a password, so none of those logins could succeed, but that can only be established by inspecting the image, not from the network. Turning both methods off leaves what is allowed unchanged and makes it observable: the evetest port scans now require that SSH offers publickey only. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 97f726a)
…aefik disable k3s only appends to a "disable" list across config.yaml.d files when the key uses the "+" suffix; a bare "disable: local-storage" in 03-enc-disable-local-path.yaml was replacing the base config.yaml's "disable: [servicelb, traefik]" instead of adding to it, silently re-enabling k3s's built-in servicelb on every fresh cluster-init. see: https://docs.k3s.io/installation/configuration#value-merge-behavior Signed-off-by: naiming-zededa <naiming@zededa.com> (cherry picked from commit b0b10f3)
On EVE-k, the cluster status server on port 12346 of the cluster IP spoke plain HTTP and answered anyone on the cluster network, including the App-Tracker's per-application dumps. It now accepts only TLS 1.3 and only requests carrying a bearer token. Every node derives the token and the server's certificate from the cluster join token, so kube-init on a joining node and zedkube on its peers authenticate the server and themselves without any key distribution. The cluster IP now serves only what other nodes need, /status and /app/. The operator-facing App-Tracker, including /cluster-app/, moves to plain HTTP on 127.0.0.1:12346, which edgeview reaches as before via tcp/127.0.0.1:12346. On 17.0-stable the joining node's wait loop is cluster-init.sh, not kube-init, so the client side is a small cluster-status-probe helper carrying a copy of kube-init's derivation, which cluster-init.sh calls in place of curl. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 042622f)
List the ports EVE's firewall admits on the cluster interface and how each is protected, note that the flannel VXLAN overlay is neither encrypted nor authenticated, and explain why a bare disable: key in a k3s drop-in re-exposes Traefik. On 17.0-stable cluster-init.sh, not kube-init, installs the local-storage drop-in, and the evetest port-scan suite is not backported, so the paragraph citing it is dropped. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ULraDivKMXrdxJxycz6g6h (cherry picked from commit 6da1ba3)
github-actions
Bot
requested review from
andrewd-zededa,
naiming-zededa and
zedi-pramodh
October 10, 2026 15:47
eriknordmark
marked this pull request as ready for review
October 10, 2026 15:58
Contributor
Author
|
The Yetus golangcilint -1 is a false positive. golangci-lint prints a per-module summary line ( |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17.0-stable #6753 +/- ##
===============================================
+ Coverage 22.35% 22.79% +0.43%
===============================================
Files 508 519 +11
Lines 94338 96135 +1797
===============================================
+ Hits 21091 21913 +822
- Misses 71441 72228 +787
- Partials 1806 1994 +188 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
milan-zededa
approved these changes
Oct 12, 2026
Merged
3 tasks done
6 of 8 tasks
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6665's non-evetest commits, plus #6232, to
17.0-stable.This closes the network exposure that the port scans in #6665 found on EVE and EVE-k:
disable:re-enabled them and exposed Traefik on ports 80 and 443.Picked with
-x, oldest first:97f726ab1FROM lfedge/eve-debughash is re-derived for this branch.b0b10f3157fddaf229, which targets the Go kube-init that 17.0 does not have. On 17.0,cluster-init.shinstallscfg-manifests/03-enc-disable-local-path.yaml, and #6232 is the fix for that file.042622f22cluster-init.sh, not kube-init, so the client is a small new Go helper,pkg/kube/cluster-status-probe, built into the kube image. It carries a copy of kube-init's derivation, andcluster-init.shpipes the join token to it in place ofcurl. Both copies' known-answer tests pin the same token and certificate hash.6da1ba360cluster-init.sh, and the paragraph citing the evetest port-scan test is dropped.#6665's evetest commit is not backported.
PR dependencies
None. #6232 is included here rather than backported separately.
How to test and validate this PR
go build(with and without-tags k),go vet -tags kandgo test -tags konpkg/pillar/cmd/zedkubepass.go vetandgo testonpkg/kube/cluster-status-probepass, including a probe against a server derived from another join token, which must fail.shellcheck pkg/kube/cluster-init.shis clean, andmake check-docker-hashes-consistencyexits 0.curl http://<node-cluster-ip>:12346/statusfrom another node gets no status.kubectl get svc -Ashows no Traefik service.debug.enable.sshset,ssh -o PreferredAuthentications=passwordis refused.Changelog notes
127.0.0.1:12346.PR Backports
Checklist
For backport PRs:
I've added a reference link to the original PR
PR's title follows the template
I've checked the boxes above, or I've provided a good reason why I
didn't check them.
🤖 Generated with Claude Code