Repository navigation
Conversation
|
Claude finished @shjala's task in 2m 58s —— View job Review: OpenSSH 10.6p2 backport to 17.0-stable
Overall this is a sound backport: the OpenSSH source build is checksum-pinned, the publickey-only drop-in ( 1. 2. Dead Backport-specific verification (can't check here):
Minor note: the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 17.0-stable #7047 +/- ##
===============================================
+ Coverage 23.53% 24.15% +0.61%
===============================================
Files 517 527 +10
Lines 95834 97411 +1577
===============================================
+ Hits 22559 23527 +968
- Misses 71358 72012 +654
+ Partials 1917 1872 -45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c7138d1 to
25a33ed
Compare
25a33ed to
f9fb451
Compare
|
Claude finished @shjala's task in 3m 6s —— View job Review: OpenSSH password-auth fix backport to 17.0-stable
Sound backport overall. The pinned r11 APKs are checksum-anchored per architecture, offline Findings (posted inline):
No blocking correctness or shipping-security issues found; #1 is the one worth resolving before merge. |
Bump Alpine to the latest built image so it picks up the latest openssh package with a critical vulnerability fixed. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br> (cherry picked from commit fb4c22e)
This commits bumps Alpine package to its latest version so it picks up a critical fix for openssh. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br> (cherry picked from commit fc203c2) Backport adjustments: retain the 17.0-stable package sources and Go 1.25.11 setting; omit packages absent from this branch and regenerate the Alpine and dependent image tags from the stable tree. Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
f9fb451 to
665b394
Compare
| # DON'T FORGET TO UPDATE THE HASH WHEN SOMETHING CHANGES! | ||
| # please see https://github.com/lf-edge/eve/blob/master/docs/BUILD.md#how-to-update-eve-alpine-package | ||
| FROM lfedge/eve-alpine:e9cb3b035e264f89523f8eca848e8baa68a1fbfd AS cache-build | ||
| FROM lfedge/eve-alpine:8c9af5568049068f10bc630065793c15d52fa931 AS cache-build |
There was a problem hiding this comment.
afaiu it should be
lfedge/eve-alpine:4635a9f93267ec0e24005aa80f2e7b1b828e5d17
|
@shjala , Alpine bump went along with the Go update, so we are good on 17.0-stable now.... I'm ok if you wan to use this PR to bump again on top of the latest image, and not on top of alpine-base, as it was bootstrapped again to pick the new OpenSSH.... |
|
Closing as superseded by the latest 17.0-stable: commit 8ef4f32 (pkg/alpine: Bootstrap from eve-alpine-base for OpenSSH fix), together with the Go/Alpine update, already supplies the OpenSSH fix. This also matches René’s confirmation in this PR. Replaying this older cache bump is no longer needed for the security fix; any future cache refresh should start from the current stable image. |
Description
Backport of #7054 to 17.0-stable, using the two relevant commits from master:
fb4c22e409e14a824eae7b995560091ee3fea21d— alpine: Bump Alpine imagefc203c28772424f4d469cf9541edd827ee63e67e— Bump Alpine package for openssh updateRefresh the Alpine 3.22 package cache to pick up the OpenSSH musl password-authentication bypass fix (Alpine
10.0_p1-r11), and refresh dependent package image pins. Both commits retain cherry-pick provenance. The unrelated guacamole download workaround from #7054 is not included.Resolve image-pin conflicts using the 17.0-stable sources: preserve its Go 1.25.11 setting, omit packages absent from this branch, and regenerate Alpine and downstream hashes. This updates the shared package cache and therefore has a broader build impact than a debug-only package change.
This replaces the previous manual APK overlay. The extra
ADD --checksumand unusedopenssh-teststages are removed, addressing those review findings. Public-key-only SSH authentication is already present in the target branch and remains enabled.How to test and validate this PR
make check-docker-hashes-consistency, SPDX checks, andgit diff --checkon the replacement revision.linuxkit pkg show-tag pkg/debugmatches the installer pin:b76f7b9595242f05de080757413415a6be38086b.09131e59512565db4e4227e33f01c7f86f5f168e.10.0_p1-r11or a newer fixed Alpine revision. Verify SSH authorized-key access, rejected password/keyboard-interactive authentication, and SFTP.Changelog notes
Refresh Alpine packages to include the OpenSSH password-authentication security fix. SSH access remains public-key only.
PR Backports
Checklist