Repository navigation
Conversation
Code Review — [16.0-stable] OpenSSH 10.6p2 backport
This is a clean, well-documented backport that mirrors the already-reviewed master #7046. Verified the important safety properties:
One minor finding (posted inline):
No correctness, security, or performance blockers found. |
3f978b1 to
9da95e5
Compare
|
Claude finished @shjala's task in 4m 49s —— View job PR Review: Backport OpenSSH 10.6p2 to 16.0-stable
SummaryThe backport is carefully constructed and I found no blocking correctness or security issues. Key things I verified:
Finding (1, minor)
Could not verify (out of scope / no tooling here)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0-stable #7048 +/- ##
================================================
+ Coverage 0 33.55% +33.55%
================================================
Files 0 15 +15
Lines 0 2962 +2962
================================================
+ Hits 0 994 +994
- Misses 0 1968 +1968 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9da95e5 to
5cb7b16
Compare
|
Claude finished @shjala's task in 2m 34s —— View job PR Review: [16.0-stable] OpenSSH backport
SummaryHeads-up: the current branch no longer matches its own PR description. The latest commit ( The safety properties I re-verified against the current code hold up:
Findings (all inline)
Could not verify (no tooling here)
No correctness or security blocker found in the build logic itself — the main asks are reconciling the stale PR docs and the two Dockerfile cleanups above. |
5cb7b16 to
b8b4931
Compare
|
Claude finished @shjala's task in 3m 24s —— View job PR Review — [16.0-stable] OpenSSH password-authentication fix
SummaryThis revision has changed substantially from what the earlier bot reviews in this thread describe: it no longer builds OpenSSH 10.6p2 from source, but overlays Alpine's signed
Findings (all inline)
Could not verify (no tooling here)
No correctness or security blocker found in the build logic itself; the main asks are findings 1–3 above. |
e4ea828 to
00d1598
Compare
00d1598 to
300a8a2
Compare
|
Claude finished @shjala's task in 3m 26s —— View job PR Review — [16.0-stable] Bump Alpine for openssh update
SummaryHeads-up for anyone reading the thread: this revision bears no resemblance to what the earlier bot reviews describe. The branch no longer touches What I verified against the current diff:
Finding (1, minor — inline)
Could not verify here (no build tooling / registry access)
No correctness, security, or performance blocker found in the diff itself — it's a clean, mechanical, internally-consistent hash bump. The one ask is reconciling the stale debug pin in the description. |
|
@shjala , please, do not bump cross-compilers in this PR, we don't need to bump it (it doesn't use any affected package from alpine), and if we bump it here the CI/CD will most likely timeout and not publish the images. We can bump cross-compilers later, btw that's why it's an exception for the docker hash checker.... |
Rebuild the 16.0-stable package cache from its existing alpine-base. Do not seed it from eve-alpine, whose cached OpenSSH r10 archives are retained by build-cache.sh. Update the rebuild marker to give the fresh cache a new content tag. Adapted from master commit fb4c22e: retain the stable bootstrap base instead of copying the populated master cache. Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
300a8a2 to
6dfd9ed
Compare
|
I'll analyze this and get back to you. |
This commits bumps Alpine package to its latest version so it picks up a critical fix for openssh. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br> (cherry picked from commit fc203c2) Backport adjustments: retain 16.0-stable package sources, compactor base and Go 1.24.6 setting; omit packages absent from this branch. Regenerate stable Alpine and dependent image tags while preserving the excluded legacy ACRN, kvm-tools and bpftrace-compiler pins. Keep cross-compilers and their consumers on the existing published images and exclude cross-compilers from the hash consistency check. Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
6dfd9ed to
18f1927
Compare
| RUN cp "/usr/local/my-installer/target/$CARGO_BUILD_TARGET/release/installer" /usr/local/my-installer/target/installer | ||
|
|
||
| FROM lfedge/eve-debug:0f92dcfac96c6115e8aa1c600d0e369b5415fc11 AS debug | ||
| FROM lfedge/eve-debug:8e18f3bedf5f8ff681713ebe0773cf20c2a907af AS debug |
There was a problem hiding this comment.
The committed debug pin here is 8e18f3bedf5f8ff681713ebe0773cf20c2a907af, but the PR description (both the test section and the 2026-11-12 rebase status) still says the installer debug pin was verified as 08a4ef585ddbdacc36cca84351254b642fac26a4. Since pkg/debug's FROM pins (recovertpm/bpftrace/eve-alpine) were bumped again in this revision, the computed pkg/debug tag changed and the documented value is stale. Please re-run linuxkit pkg show-tag pkg/debug, confirm it yields 8e18f3be…, and update the description so reviewers following the test steps don't hit a mismatch. (make check-docker-hashes-consistency remains the real gate.)
|
Claude finished @shjala's task in 2m 34s —— View job PR Review — [16.0-stable] Bump Alpine for openssh update
@rene's feedback — both addressed ✅
Consistency — clean mechanical bump ✅
Finding (1, minor — inline)
Could not verify here (no registry/build tooling)
No correctness, security, or performance blocker found — the diff is an internally-consistent hash bump that correctly incorporates @rene's feedback. |
| # based eve-alpine on this branch: their upstream sources (ACRN 2.x, | ||
| # qemu 5.2) do not build with the alpine 3.22 toolchain. | ||
| IGNORE_DOCKERFILE_HASHES_PKGS=alpine acrn acrn-kernel kvm-tools | ||
| IGNORE_DOCKERFILE_HASHES_PKGS=alpine acrn acrn-kernel kvm-tools cross-compilers |
There was a problem hiding this comment.
Adding cross-compilers here is the right call per @rene's request (avoids the CI timeout and keeps the consumers pinned to the old eve-cross-compilers:65d07c4c…). However, every other entry in this list is explained by the comment block just above (installer's rationale, and why acrn/acrn-kernel/kvm-tools stay on alpine 3.16), while cross-compilers is added with no explanation. A future maintainer won't know this is a temporary exclusion meant to be lifted once cross-compilers is rebuilt on the new eve-alpine.
Consider a one-line note, e.g.:
# cross-compilers is temporarily excluded: it does not consume any affected
# alpine package, so it is intentionally left on the old eve-alpine hash to
# avoid rebuilding it here (CI timeout); bump it in a follow-up.Also worth confirming before merge: pkg/cross-compilers/Dockerfile still FROMs eve-alpine:a5885b38…, so that old image must remain pullable whenever cross-compilers is next rebuilt.

Description
Adapt the OpenSSH package-cache update from #7054 to 16.0-stable. Rebuild from the branch's existing
eve-alpine-base, rather than a populatedeve-alpinecache:build-cache.shretains cached APKs, so the previously selected image would retain vulnerable OpenSSH10.0_p1-r10.Update the cache rebuild marker to produce a new image tag and regenerate dependent pins. Preserve stable package sources, Go 1.24.6 and the compactor base. Keep cross-compilers and all their consumer references unchanged; add cross-compilers to the hash-check exceptions as requested in review. Existing ACRN, acrn-kernel, kvm-tools and bpftrace-compiler exceptions remain unchanged.
The bootstrap commit adapts master commit
fb4c22e409e14a824eae7b995560091ee3fea21d; the dependent-image update derives fromfc203c28772424f4d469cf9541edd827ee63e67e. Public-key-only hardening is already present on this branch. The manual APK overlay and unused openssh-test stage are absent.How to test and validate this PR
make -o pkg-deps.mk check-docker-hashes-consistency), SPDX and whitespace checks. The make option suppresses dependency-file generation, not hash validation.linuxkit pkg show-tag: Alpinecda433a7600c2486a9011c2de8b7e676483e25ac; debug8e18f3bedf5f8ff681713ebe0773cf20c2a907af. The installer debug pin matches.10.0_p1-r11or a newer fixed revision; new image contents have not been verified locally.sshd -Tdisables password and keyboard-interactive authentication, and test authorized SSH keys and SFTP. Run Eden/evetest after approval.Changelog notes
Refresh Alpine packages to include the OpenSSH password-authentication security fix. SSH remains public-key only.
PR Backports
Checklist