Repository navigation
[14.5-stable] debug: skip upstream OpenSSH tests only on RISC-V - #7067
Conversation
852810f to
4ec52cc
Compare
|
Claude finished @shjala's task in 3m 18s —— View job Code review
I reviewed the 6 changed files. One blocking issue, posted inline; details below. Blocking
Minor (non-blocking, no change required)
Checked and fine
|
4ec52cc to
a8d98f5
Compare
|
Claude finished @shjala's task in 1m 46s —— View job Code review
The PR has been re-scoped since the previous review to a minimal, self-contained change: the upstream Findings
I confirmed there are no remaining Overall: low-risk, clean change consistent with the stated goal. No blocking issues. |
OpenSSH 10.6p2 aborts when seccomp setup fails under QEMU user-mode, causing the upstream connection tests to block RISC-V publishing after lf-edge#7049. Skip that upstream test step only for the riscv64 target; retain it for amd64 and arm64. Keep the SSHole regression and debug test stage unchanged. Refresh the installer debug-image pin. No OpenSSH source or production sandbox configuration changes. Signed-off-by: Shahriyar Jalayeri <shahriyar@posteo.de>
a8d98f5 to
b19c5b0
Compare
|
Claude finished @shjala's task in 1m 53s —— View job Code review
This PR has been substantially simplified since my earlier review. The RISC-V test-harness approach ( No blocking issues
One note (non-blocking)
Trade-off worth acknowledging (not a change request)Skipping
|
| RUN cp "/usr/local/my-installer/target/$CARGO_BUILD_TARGET/release/installer" /usr/local/my-installer/target/installer | ||
|
|
||
| FROM lfedge/eve-debug:65486b943c4d12ad05e9aa22ace57e4d1cf4adaa AS debug | ||
| FROM lfedge/eve-debug:c655bb06a9e48d41a29a2cdb9cffc381fc8f4944 AS debug |
There was a problem hiding this comment.
The debug pin bump is required because pkg/debug/Dockerfile changed. Per your PR description the branch's hash-consistency checker excludes this FROM, so nothing in CI validates that c655bb06a9e48d41a29a2cdb9cffc381fc8f4944 equals the tag the current pkg/debug source produces. Please double-check it against linuxkit pkg show-tag pkg/debug on this branch — a stale pin here would silently build the installer against the old debug image (the one that still runs make tests on riscv64), defeating the fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 14.5-stable #7067 +/- ##
===============================================
+ Coverage 24.97% 32.18% +7.20%
===============================================
Files 8 14 +6
Lines 1185 2663 +1478
===============================================
+ Hits 296 857 +561
- Misses 820 1806 +986
+ Partials 69 0 -69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

Description
Skip the upstream OpenSSH
make testsinvocation only whenTARGETARCH=riscv64, to unblock RISC-V publishing after #7049. OpenSSH 10.6p2 treats seccomp setup failures as fatal, while QEMU user-mode cannot install seccomp filters; the upstream connection tests therefore fail after successful compilation.amd64 and arm64 continue to run the existing upstream test suite. Only RISC-V skips that step. Our SSHole/public-key/SFTP regression, production authentication checks and debug Go test stage remain unchanged. OpenSSH source and the production seccomp sandbox are unchanged.
Refresh the installer debug-image pin. No workflow changes, VM infrastructure or new scripts.
How to test and validate this PR
git diff --checkpass. Independently compared the installer pin withlinuxkit pkg show-tag pkg/debug, since the branch's checker excludes that Dockerfile.make tests.Changelog notes
Unblock RISC-V image publishing by skipping upstream OpenSSH tests only on RISC-V.
PR Backports
Master #7046 likewise uses Alpine packages without this invocation.
Checklist