Skip to content

[16.0-stable] zedmanager: drive purge state machine to completion in doUpdate - #6846

Closed
milan-zededa wants to merge 1 commit into
lf-edge:16.0-stablefrom
milan-zededa:16.0-backport-5618-purge-state-machine
Closed

milan-zededa wants to merge 1 commit into
lf-edge:16.0-stablefrom
milan-zededa:16.0-backport-5618-purge-state-machine

Conversation

@milan-zededa

@milan-zededa milan-zededa commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Description

Backport of #5618 to 16.0-stable.

Clean cherry-pick with -x of b4460199b2, no conflicts.

It is one of three zedmanager purge fixes (together with the backports of
#5742 and #6257) that TestVMAppPurgeAfterPowerCycle needs: without them a
purge requested while the device is down never completes after it boots.

PR dependencies

None.

How to test and validate this PR

Covered by the evetest test TestVMAppPurgeAfterPowerCycle (added to 16.0-stable by #6842):

EVETEST_EVE_VERSION=<16.0-stable build with this PR> make evetest NAME=TestVMAppPurgeAfterPowerCycle

The test passes only with this PR together with the backports of #5742 (#6847) and #6257 (#6848).

Changelog notes

Fixed application purge not being driven to completion by zedmanager in some cases.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

  • I've added a reference link to the original PR
  • PR's title follows the template

And the last but not least:

  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Fix app instance getting permanently stuck in HALTING state with
PurgeInprogress=BringDown during a purge operation.

The purge state machine has the following transitions:

  DownloadAndVerify → BringDown → RecreateVolumes → BringUp

The BringDown → RecreateVolumes transition was only implemented in
removeAIStatus(), which is called from updateAIStatusUUID() when it
observes PurgeInprogress==BringDown. However, doUpdate() also drives
the DownloadAndVerify → BringDown transition and calls doRemove()
inline. When doRemove() completes synchronously (no domain or network
to tear down), doUpdate() falls through with PurgeInprogress still set
to BringDown. If no subsequent event triggers updateAIStatusUUID()
(e.g. no DomainStatus, AppNetworkStatus, or VolumeRefStatus changes),
removeAIStatus() is never called and the state machine stalls.

This happens in practice when:
1. A purge counter mismatch is detected on reboot
2. handleCreateAppInstanceStatus calls doUpdate directly
3. The low-priority app boot path (checkLowPriorityApps) calls doUpdate
4. doRemove completes instantly because nothing is running
5. Nothing triggers another status re-evaluation

After doRemove() completes, drive the state machine forward to
RecreateVolumes and call purgeCmdDone() to persist the purge counter.
This ensures the purge completes regardless of which code path invoked
doUpdate(), and prevents the purge from being re-detected on subsequent
reboots.

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
(cherry picked from commit b446019)
Signed-off-by: Milan Lenco <milan@zededa.com>
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.89%. Comparing base (c9e7c2a) to head (e2fb533).
⚠️ Report is 26 commits behind head on 16.0-stable.

Additional details and impacted files
@@               Coverage Diff               @@
##           16.0-stable    #6846      +/-   ##
===============================================
- Coverage        29.12%   26.89%   -2.24%     
===============================================
  Files               10       25      +15     
  Lines             1133     4332    +3199     
===============================================
+ Hits               330     1165     +835     
- Misses             768     2938    +2170     
- Partials            35      229     +194     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eriknordmark

Copy link
Copy Markdown
Contributor

The Eden User Apps suite fails here at purge_not_activated_test.txt:60 (job). This PR backports only #5618; the test also needs #5742, which fixes purging an app that was never activated.

#6847 carries this same commit plus the #5742 backport, and passes User Apps. These must merge as a pair: merge #6847, which makes this PR redundant, rather than this one on its own.

@milan-zededa

Copy link
Copy Markdown
Contributor Author

Closing: #6847 is stacked on this PR and already contains this commit (the backport of #5618, e2fb533f6e) as its second commit. Merging #6847 brings it in, so this PR has nothing left to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants