Repository navigation
[16.0-stable] eve-k: fix purge leaving stale VMIRS generations and volume refs - #6848
Merged
eriknordmark merged 1 commit intoOct 26, 2026
Conversation
…firm On a purge, doInstall parks the old VolumeRefStatus and waits for volumemgr to confirm the delete. If volumemgr has no live status for that reference in this boot (for example because a reboot wiped the ephemeral state), the confirmation never comes. The app stays in DownloadAndVerify and never asks for the new volume. zedmanager now looks at volumemgr's live status first, and drops the reference if it is already absent. Only the zedmanager part of the original change is picked. The kubevirt changes in it are not applicable to this branch. (cherry picked from commit 9c2eecf) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16.0-stable #6848 +/- ##
===============================================
- Coverage 29.12% 26.73% -2.40%
===============================================
Files 10 25 +15
Lines 1133 4332 +3199
===============================================
+ Hits 330 1158 +828
- Misses 768 2947 +2179
- Partials 35 227 +192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rene
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6257 to
16.0-stable, partially: only the generic zedmanager part.The original change is mostly kubevirt (eve-k) code, which does not exist in
16.0, plus evetest purge tests for the kube path. What applies to 16.0 is
defect 3 of the commit message: on a purge,
doInstallparks the oldVolumeRefStatusand waits for volumemgr to confirm its deletion; if volumemgrhas no live status for it in this boot (e.g. a reboot wiped the ephemeral
state), the confirmation never comes and the app stays in
DownloadAndVerify.zedmanager now drops the reference when volumemgr's live status is already
absent.
The cherry-pick (with
-x, from9c2eecf8de, via its17.0-stablebackport)conflicted in the kubevirt files; the conflicts are resolved by dropping all
kubevirt changes, the kubevirt documentation, and the
DomainStatus.DomainIdcomment that describes only kubevirt. Only
zedmanager/updatestatus.goand itsunit test are kept, and the commit message is reduced to that part.
Without this fix
TestVMAppPurgeAfterPowerCyclefails: the purge issued whilethe device is down never completes after boot (the persisted purge counter does
not advance).
PR dependencies
None.
How to test and validate this PR
Covered by the evetest test
TestVMAppPurgeAfterPowerCycle(added to16.0-stableby #6842):The test passes only with this PR together with the backports of #5618 (#6846) and #5742 (#6847).
Changelog notes
Fixed application purge not completing when the purge was requested while the device was powered off.
Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.