Repository navigation
evetest-pr: run one evetest per PR head, supersede stale runs - #6970
Merged
Merged
Conversation
The concurrency group of evetest-pr was built from the head_branch of the triggering PR Gate run. That is the PR branch for a review-triggered gate but the default branch for a workflow_run-triggered one, so the two triggers of a single PR landed in different groups (and both ran Claude to decide the skips and then the whole suite), while all workflow_run-triggered gates of unrelated PRs shared one group and cancelled each other. Drop the group and instead decide in discover-suites, before Claude is asked anything, using the PR number from the gate's run-context: - a trigger for a commit that another active run already tests is ignored; - a trigger for a new head commit of the PR cancels the active run of the older commit; - a trigger for a commit that is no longer the PR head is ignored. Active runs are recognised by an evetest-active-<pr>-<sha> artifact that each run uploads once it has passed the check; unlike a per-commit status it can be found after a force-push. A cancelled or timed out run leaves the suites that never got a runner with their "Queued" status, so add a cleanup job that turns the statuses of this run that are still pending into errors. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
requested review from
eriknordmark,
rene,
shjala and
yash-zededa
as code owners
October 29, 2026 14:03
5 of 7 tasks
rene
approved these changes
Oct 29, 2026
Merged
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The concurrency group of
evetest-prwas built fromhead_branchof thetriggering PR Gate run. That is the PR branch for a review-triggered gate but
the default branch for a
workflow_run-triggered one. As a result:landed in different groups, so both ran Claude to decide the skips and then
the whole suite, occupying the evetest runners twice;
workflow_run-triggered gates of unrelated PRs shared one group andcancelled each other.
The workflow-level group is dropped. Instead,
discover-suitesdecides beforeClaude is asked anything, using the PR number from the gate's run-context:
commit;
Active runs are recognised by an
evetest-active-<pr>-<sha>artifact that eachrun uploads once it has passed the check. Unlike a per-commit status, it can be
found after a force-push.
A cancelled or timed-out run leaves the suites that never got a runner with
their "Queued" status, so a new
cleanupjob turns the statuses of that runthat are still pending into errors.
discover-suitesnow hasactions: write, needed to cancel a superseded run.How to test and validate this PR
On a PR that is approved and has a finished PR build:
/evetest) while the first evetest-pr run is active: the second run muststop in
discover-suiteswithout calling Claude, and the first run mustcontinue.
commit must be cancelled and the new one must start.
Evetest / <suite>statuses of the old commit thatwere still pending must turn into errors.
This is a CI workflow change that can only be exercised on GitHub itself.
Changelog notes
None. No user-facing changes (CI workflow only).
PR Backports
Checklist
check them.
The documentation and device-test boxes do not apply: this only changes a CI
workflow, and it has not been run on GitHub yet.
🤖 Generated with Claude Code