Repository navigation
feat(native): make the topbar the window's title bar - #840
Merged
Merged
Conversation
The native window opened under the system's title bar, a second strip over the topbar; on GNOME it was Gio's own, light and blind to the theme. The window now opens undecorated: the empty run of the topbar moves it (a double click maximizes), and minimize, maximize and close sit beside Settings, drawn in each desktop's look: Windows 11's corner buttons, GNOME's round ones on the side and in the order of button-layout, Breeze under Plasma. macOS keeps its own traffic lights in a 78dp reserve at the left, the lich mark after them. A desktop that decorates its windows itself keeps its bar and gets no buttons: a Wayland compositor that answers server-side to the request for client-side decorations, or an X11 tiling WM. The Gio fork (pinned here) carries the Wayland and X11 halves; docs/ceilings.md says what is out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native window opened under the system's title bar, a second strip over the topbar (on GNOME, Gio's own light bar, blind to the theme). The topbar is now the title bar. Mockup: https://claude.ai/artifact/1TNrcGD7UVntLeL5CN4kNP
Decorated(false). The empty run of the topbar after the tabs moves the window; a double click maximizes or restores.button-layout(read from the settings portal), Breeze's glyphs whenXDG_CURRENT_DESKTOPis KDE._NET_WM_NAME).c0397443(branch drop-event): Wayland asksxdg-decorationfor the mode the app wants; X11 sets_MOTIF_WM_HINTS, moves and resizes through_NET_WM_MOVERESIZEand keeps the WM's decoration under a tiling WM; both turn a double click on a move area into maximize.docs/ceilings.mdnames what is out (Snap Layouts, KDE decoration themes, X11 corners and shadow, macOS light position and double click).Verification
native/:gofmt,go vet ./...,go test ./...clean; fork: new caption tests pass.--virtualwith an isolated backend.set_mode(1)thenconfigure(1)); KDE and GNOME buttons drawn (-shot)._MOTIF_WM_HINTS = 0x2, 0x0, ...,WM_CLASS lich, no frame, GNOME buttons drawn.