Repository navigation
DM-54789-v30: Drop host/port/scheme from VCR match_on so cassettes replay anywhere - #200
Merged
Merged
Conversation
The cassettes were recorded with HTTPS_PROXY active at USDF, baking sdfproxy.sdf.slac.stanford.edu:3128 into every URI. Outside USDF (and seemingly now also at USDF, after some library or NO_PROXY drift) the host/port matchers reject every replay. The recorded paths uniquely identify each service, so matching on method/path/query/body is enough and makes replay independent of proxy state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Is there a reason we shouldn't merge this to |
Collaborator
Author
|
This is a commit cherry-picked from the main branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cassettes were recorded with HTTPS_PROXY active at USDF, baking sdfproxy.sdf.slac.stanford.edu:3128 into every URI. Outside USDF (and seemingly now also at USDF, after some library or NO_PROXY drift) the host/port matchers reject every replay. The recorded paths uniquely identify each service, so matching on method/path/query/body is enough and makes replay independent of proxy state.