Skip to content

DM-54789-v30: Drop host/port/scheme from VCR match_on so cassettes replay anywhere #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwittgen merged 1 commit into from
Nov 2, 2026
Merged

DM-54789-v30: Drop host/port/scheme from VCR match_on so cassettes replay anywhere #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,20 @@ def getVcr():
"""Get a VCR object for use in tests.

Use record_mode="none" to run tests for normal operation. To update files
or generate new ones, make sure you have a working connection to the EFD at
all the relevant sites, and temporarily run with mode="all" via *both*
python/pytest *and* with scons, as these generate slightly different HTTP
requests for some reason. Also make sure to do all this at both the summit
and USDF. The TTS is explicitly skipped and does not need to follow this
procedure.
or generate new ones, make sure you have a working connection to the EFD
and temporarily run with mode="all" via *both* python/pytest *and* with
scons, as these generate slightly different HTTP requests for some reason.
Also make sure to do this at the summit (USDF coverage is provided by the
same recording, since matching ignores host/port and so is independent of
whether requests go through a proxy). The TTS is explicitly skipped and
does not need to follow this procedure.
"""
dirname = os.path.dirname(__file__)
cassette_library_dir = os.path.join(dirname, "data", "cassettes")
safe_vcr = vcr.VCR(
record_mode="none",
cassette_library_dir=cassette_library_dir,
path_transformer=vcr.VCR.ensure_suffix(".yaml"),
match_on=["method", "scheme", "host", "port", "path", "query", "body"],
match_on=["method", "path", "query", "body"],
)
return safe_vcr
Loading