Skip to content

Compile the pre-26 NMS modules with JDK 21 through a toolchain #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Travja merged 1 commit into from
Oct 23, 2026
Merged

Compile the pre-26 NMS modules with JDK 21 through a toolchain #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codex-nms/codex-nms-v26_2/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

<properties>
<java.version>21</java.version>
<nms.jdk>25</nms.jdk>
</properties>

<dependencies>
Expand Down
1 change: 1 addition & 0 deletions codex-nms/codex-nms-v26_3/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

<properties>
<java.version>21</java.version>
<nms.jdk>25</nms.jdk>
</properties>

<dependencies>
Expand Down
23 changes: 23 additions & 0 deletions codex-nms/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@
<name>CodexNMS</name>
<description>A collection of NMS libraries for Codex</description>

<properties>
<!-- JDK each NMS module compiles with, through a Maven toolchain (see the jdkToolchain below).
Since JDK 22, javac also reads type annotations from the Spigot jars and then fails on
classes they reference that aren't on the classpath (e.g. datafixerupper), so the older
versions compile on 21. The 26.x modules override this with 25, because those Spigot
jars are Java 25 class files. -->
<nms.jdk>21</nms.jdk>
</properties>

<modules>
<module>codex-nms-v1_16_5</module>
<module>codex-nms-v1_17_1</module>
Expand Down Expand Up @@ -56,6 +65,20 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<jdkToolchain>
<version>${nms.jdk}</version>
</jdkToolchain>
</configuration>
</plugin>
</plugins>
</build>

<licenses>
<license>
<name>MIT License</name>
Expand Down
Loading