[Travja]

This fixes the failed 1.2.0 release (run 40011583260).

What failed

BuildTools succeeded for every Spigot version. The deploy then failed compiling codex-nms-v1_20_1 on JDK 25:

spigot-1.20.1-R0.1-SNAPSHOT.jar(/net/minecraft/server/level/WorldServer.class): error: Cannot attach type annotations
  @javax.annotation.Nullable to net.minecraft.server.level.WorldServer.a:
  class file for com.mojang.datafixers.util.Pair not found

Since JDK 22, javac reads type annotations from the jars it compiles against, so it now needs classes those annotations reference. On the runner, datafixerupper wasn't on that module's classpath. The release runs on JDK 25 because Codex's main modules need WorldEdit/WorldGuard's Java 25 classes, but only the 26.x NMS modules need 25 themselves.

Change

• codex-nms/pom.xml: the compiler picks its JDK through jdkToolchain = ${nms.jdk}, default 21. All NMS modules inherit this.
• codex-nms-v26_2 and codex-nms-v26_3 set nms.jdk to 25, since their Spigot jars are Java 25 class files.
• Maven itself still runs on JDK 25, so the main modules are unchanged.

The shared release workflow writes a toolchains.xml with the runner's JDK 21 and 25 (.github patch 0006, which also adds deployAtEnd). Without a toolchains.xml, as in a local build, the compiler just uses the JDK Maven runs on.

Before merging / re-running the release

• .github patch 0006 is applied. Without the toolchains.xml it writes, the compiler falls back to JDK 25 and the release fails the same way.
• The partial 1.2.0 upload is removed from repo.travja.dev releases: codex-parent, codex-bungee and codex-api 1.2.0. The failed run deployed those modules before it reached the broken one. The 1.2.0 tag was already removed by the workflow.

Testing

On a real Spigot 1.20.1 jar from BuildTools:

• Reproduced the CI error: JDK 25, no toolchain, datafixerupper excluded from the classpath (as on the runner).
• Same setup with a JDK 21 toolchain: the toolchain is picked (Toolchain in maven-compiler-plugin: JDK[…java-21…]) and the build succeeds. The delombok step still prints the message, but it's non-fatal and was already there.
• codex-nms-v26_3 against the real 26.3 jar: compiles with the JDK 25 toolchain.
• Without any toolchains.xml, both modules fall back to the running JDK instead of failing.

---

Generated by Claude Code