Repository navigation
test(committor): cover buffered dlp v2 settlement - #285
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
snawaz
marked this pull request as ready for review
October 29, 2026 08:34
snawaz
force-pushed
the
test/dlp-v2-buffered-settlement
branch
from
November 2, 2026 13:15
e702334 to
317047c
Compare
Exercise commit and commit-with-undelegation for an 8 KiB v2 cell whose payload is fully rewritten. Check the exact settled snapshot and owner, then inspect successful base-chain transactions to require v2 buffer writes, CommitFinalizeFromBuffer, and CloseStateBuffer. Wait for buffer cleanup through the existing bounded query mechanism. Check that the derived StateBuffer account is gone, and preserve the commit-ID or delegation-state checks for the corresponding final state. Reuse the lifecycle fixture and share instruction inspection with the following mixed-version scenario. Closes #282
snawaz
force-pushed
the
test/dlp-v2-buffered-settlement
branch
from
November 2, 2026 13:23
317047c to
b0bff99
Compare
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds buffered v2 commit and undelegation coverage using 8 KiB cells. It checks exact settled data and ownership, confirms buffer writes and settlement in successful base-chain transactions, and waits for buffer closure.
Closes #282
Reviewer notes
Built on #284. Live qualification remains pending the Linux run with validator #1860.