Repository navigation
test(committor): cover mixed legacy and dlp v2 settlement - #287
Merged
snawaz merged 2 commits intoNov 2, 2026
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Oct 29, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
marked this pull request as ready for review
October 29, 2026 08:34
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Oct 29, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Oct 31, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
force-pushed
the
test/dlp-mixed-settlement
branch
from
November 2, 2026 13:15
6315f0a to
279e995
Compare
Delegate one legacy cell and one v2 cell under the same owner program and schedule them in one intent. Repeat with undelegation after another write. Require successful receipts containing both accounts, exact base-chain snapshots, commit-ID advancement, and ownership return. Inspect the landed transactions for both legacy and v2 CommitFinalize instructions and the v2 Undelegate instruction. Verify the v2 delegation state is closed. Reuse the existing legacy cell builder and the v2 fixture from the parent PRs. Document the two additional scenario selections. Closes #283
snawaz
force-pushed
the
test/dlp-mixed-settlement
branch
from
November 2, 2026 13:23
279e995 to
f6cf8a7
Compare
This was referenced Nov 2, 2026
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 2, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 2, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 2, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
bmuddha
pushed a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 3, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 3, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 5, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 5, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
snawaz
added a commit
to magicblock-labs/magicblock-validator
that referenced
this pull request
Nov 5, 2026
Pin RedSuite to the top of its three-PR v2 coverage stack: lifecycle, buffered settlement and cleanup, and mixed legacy/v2 intents. Read the DLP revision from the validator dependency and require RedSuite to use the same interface revision. Build that program with the SBF fixtures, include its revision in the artifact cache key, and load the result through REDSUITE_DLP_SO instead of the cloned mainnet program. This enables real v2 qualification on Linux CI. The scenarios deliberately require normal v2 discovery and activation; they do not seed legacy PDAs to bypass the remaining Chainlink integration gap. RedSuite stack: magicblock-labs/redsuite#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds one legacy cell and one v2 cell to the same commit intent, then undelegates both in a second intent. It checks exact data, commit IDs, ownership return, and the DLP instruction versions used on the base chain.
Closes #283
Reviewer notes
Built on #285. Uses the existing legacy fixture and the v2 setup from #284. Live qualification remains pending the Linux run with validator #1860.