Repository navigation
Remove workloadType from the Management API project - #89
Conversation
The Cloud API no longer returns it (meilisearch/meilisearch-cloud#8092). Regenerate the client and drop it from the test fixture. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
What
Remove
workloadTypefrom the generated Management API client and from the test fixture of a project, because the Cloud API no longer returns it (meilisearch/meilisearch-cloud#8092).Contract
docs/contract/commands.md, or the name the maintainers chose is recorded as an exception with its reason; each route is reachable by a distinct set of flags (or this pull request changes the contract and nothing else) — no command or flag changessrc/lib/output.ts, errors throughsrc/lib/errors.ts— unchanged$EDITOR, unless it is an interactive command of ADR 0015; adeletecommand spreadsBaseCommand.confirmFlagsand its examples carry--yes— unchangedmeili --helpshows; the detail goes in the next paragraph. It says whether the command is interactive, never who it is for — no description changesBaseCommandand never callsprocess.exit; every question goes throughsrc/lib/terminal.tswith a stablepromptid, and every option ofchoosehas a stableid, unless the option is the user's own data — unchangedfetchoutsidesrc/lib/clients/— unchangedTests
--helpsnapshot added or updated on purpose — no--helpchangesproject add,list,viewandupdatesnapshots loseworkloadType, in JSON and in the text viewpnpm lint,pnpm typecheck,pnpm testpass locally — lint, typecheck, and theunitandcontractprojects pass (660/660). Theintegration-meilisearchproject could not run: port 7700 was taken by a Meilisearch container that is not the one of this repository, with another master key (invalid_api_key). The change touches no Meilisearch command.Simplicity
src/lib/, is used by this command, and is named below — nothing shared addedDocs
docs/contract/updated for every name, flag, variable or code this change adds or renames, or nothing to update — nothing to update,docs/never namedworkloadTypeCLAUDE.md— no prose changesHousekeeping
oclif.manifest.jsonregenerated —pnpm gen:manifestgives no diff.changeset/README.md, or the change is invisible to users of the package (docs of this repository, tests, CI) — no changeset: the CLI returns the API body as it is, so users already stopped seeingworkloadTypewhen the Cloud API shippedNotes for the reviewer
The diff comes from
pnpm openapi:managementandpnpm gen:management, plus one line removed fromtest/helpers/management-handlers.tsandpnpm test -u.🤖 Generated with Claude Code
Summary by CodeRabbit