Skip to content

Break the meili config set line of the code samples after PROJECT_NAME - #92

Merged
curquiza merged 1 commit into
mainfrom
code-samples-config-set-line-break
Nov 9, 2026
Merged

curquiza merged 1 commit into
mainfrom
code-samples-config-set-line-break

Conversation

@curquiza

@curquiza curquiza commented Nov 9, 2026

Copy link
Copy Markdown
Member

What

In .code-samples.meilisearch.yaml, the meili config set line of every sample (178) now breaks after --project PROJECT_NAME, with a \ continuation:

meili config set --project PROJECT_NAME \
  --project-url MEILISEARCH_URL --project-api-key API_KEY

The line is shorter in the documentation, and the indentation matches the other continued lines of the samples.

Contract

  • The command name and flags derive from its routes: no command changes
  • Output goes through src/lib/output.ts, errors through src/lib/errors.ts: no code changes
  • The command never waits for a human: no command changes
  • The description starts with one short sentence: no command changes
  • What the user types sends analytics: no command changes
  • The command never speaks HTTP itself: no command changes

Tests

  • --help snapshot: no command changes
  • JSON output snapshot: no command changes
  • Integration test: no command changes
  • pnpm lint, pnpm typecheck, pnpm test pass locally: lint and typecheck pass. In pnpm test, every unit and contract test passes, test/contract/docs.test.ts included. The integration tests fail because no local Meilisearch was running; they fail the same way on main.

Simplicity

  • Nothing in the diff exists for a case the API cannot produce
  • Nothing shared added

Docs

  • docs/contract/: nothing to update
  • The ADRs: nothing touched
  • No accepted ADR was edited
  • New or changed prose follows rule 17: no prose changed
  • .code-samples.meilisearch.yaml updated: this is the change itself

Housekeeping

  • oclif.manifest.json: no command changes
  • Changeset: the change is invisible to users of the package
  • No new dependency

Notes for the reviewer

One sed on the file. Every meili config set line changed the same way, whatever its URL or key.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@curquiza
curquiza merged commit 28f8a86 into main Nov 9, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant