Conversation
The operator writes `[REDACTED]` in place of the values of headers and message properties with names that often hold secrets. Tell users which names match, and that other names are still logged as they are.
PR Summary by QodoDocument secret-value redaction in Message Processing logs
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. Documentation can precede the operator release
|
| } | ||
| ``` | ||
|
|
||
| Starting with mirrord Operator `3.215.0`, the Operator writes `[REDACTED]` in place of the value of a header or message property when its name often holds a secret. The Operator uses only the ASCII letters and digits of the name, in lowercase, and the name matches when they contain one of these parts: `accesskey`, `apikey`, `appcheck`, `auth`, `cookie`, `credential`, `csrf`, `encryptioncustomerkey`, `encryptionkey`, `functionskey`, `hmac`, `jwt`, `oidcdata`, `passphrase`, `passw`, `privatekey`, `pwd`, `secret`, `session`, `signature`, `subscriptionkey`, `token`, or `xsrf`. For example, the values of `Authorization`, `Cookie`, `X-Api-Key`, `api.key`, `Client-Secret` and `db_password` are redacted. The name stays in the record, so you can still see which headers or properties a message had. |
There was a problem hiding this comment.
1. Documentation can precede the operator release 🔗 Cross-repo conflict ☼ Reliability
The monitoring page announces header and property redaction starting with Operator 3.215.0, while the pinned operator branch containing the implementation still declares version 3.214.0. Publishing this documentation before the release/version bump reaches customers can describe behavior that their installed Operator does not provide.
Agent Prompt
## Issue description
The documentation claims that redaction starts with Operator 3.215.0, but the related operator branch currently declares version 3.214.0. Merging or publishing the documentation before the operator release/version bump is available can cause users of the documented version to expect redaction that is not present.
## Fix Focus Areas
- docs/managing-mirrord/monitoring.md[178-178]
- /cross_repos/operator/Cargo.toml[19-19]
- /cross_repos/operator/crates/operator-context/src/event/functional_log.rs[165-202]
## Recommended Fix
Merge or publish this documentation only after the operator change is released under version 3.215.0, and verify the release/version bump before merging. Alternatively, keep the documentation version aligned with the actually released operator version.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
[Low risk] Documents secret redaction in monitoring logs. No actionable defect was established; merge only after the stated Operator release and version are confirmed. SummaryThe PR documents name-based redaction of secret-bearing HTTP headers and message properties in Message Processing logs.
Reviews (1) · Last reviewed commit: "Monitoring: Document redacted secret hea..." |
For COR-1962, operator change: metalbear-co/operator#2553.
The operator now writes
[REDACTED]in place of the values of headers and message properties whose names often hold secrets, in theMessage Processingfunctional logs. This updates the monitoring page: therequest_headersandmessage_propertiesfields, which name parts match and how, and a warning that other names and secrets inside values are still logged.Customers need the full list for their security reviews, so the page shows all the parts. The operator code has a comment that tells maintainers to change both together.
Merge this only after the operator release that has the change. The page says
3.215.0, the next release after3.214.0. Check that number before you merge.