Repository navigation
Guard restored nested recursor field counts (upstream nanoda_lib #63) - #120
Draft
heathsanchez wants to merge 4 commits into
Draft
heathsanchez wants to merge 4 commits into
heathsanchez wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounded soundness repair (draft; qualification pending)
The current published Flash kernel checks the reconstructed nested recursor's rule expression but does not compare the exported
ctor_telescope_size_wo_paramswith the independently reconstructed count. That count determines which constructor arguments iota-reduction consumes.This branch adds the precise invariant already fixed in upstream
ammkrn/nanoda_libPR #63, with attribution in source. It targets the Arena'sbugs/nested-rec-rule-nfieldsincorrect acceptance. No broader soundness/completeness result is claimed.The included Actions test builds the exact published Flash commit
78c7502bac8a5ba000057b3f083bc0595ac65750and the patched candidate under matched Rust flags; runs the downloadable official Arena small-case suite; requires before ACCEPT → after REJECT for the target and unchanged exit codes for all other tested, non-performance cases. It preserves the input archive SHA, binary SHAs, and a case-by-case artifact even when a control fails. Full Mathlib and heavy performance tests are outside this gate and must be qualified separately.Please keep this PR draft until its paired regression and subsequent performance/completeness checks are reviewed.