recorder: bigger glass action badges on the preview card - #169
Merged
Conversation
- grow the ✕ / ✂ / 🗑 badges 28→40pt (48pt effective targets with hitSlop, over the 44pt HIG minimum) and bump their icons 14/16→18/20pt - convert the badges, the time readout pill, and the paused ▶ overlay to GlassPill — Liquid Glass on iOS 26+, the usual dark scrim elsewhere - grow the ▶ overlay 56→64pt with a 28pt glyph - badge shape and position split: Pressable owns placement + hit area, GlassPill owns the surface, matching camera-controls
There was a problem hiding this comment.
Pull request overview
This PR updates the recorder’s floating preview card controls to improve usability (larger tap targets) and visual consistency with the app’s “glass over live media” chrome by routing the overlay UI through GlassPill.
Changes:
- Increased preview-card action badge sizes (✕ / ✂ / 🗑) and icon sizes, while keeping the existing layout.
- Moved badge surfaces, time readout pill, and paused ▶ overlay surface rendering to
GlassPill(Liquid Glass on iOS 26+, scrim fallback elsewhere). - Reworked positioning so
Pressableowns placement + hit area whileGlassPillowns surface styling.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 14, 2026
Collaborator
|
Cosmetic changes. Single file updates. Looks good. 👍 |
SarkarShubhdeep
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164. Part of #168 (the preview-card items).
The three action badges on the floating preview card were 28×28pt circles with 14–16pt icons — small and easy to mis-tap, especially the destructive 🗑. They also used flat
rgbascrims right next to the recorder's glass chrome.Changes
Bigger tap targets (#164)
Liquid Glass (#168, preview card)
GlassPill— native Liquid Glass on iOS 26+, the same dark scrim as before everywhere elsecamera-controlspattern:Pressableowns placement + hit area,GlassPillowns the surface (nobackgroundColorfrom callers)Testing
tsc --noEmitand ESLint clean