Repository navigation
Conversation
…ud analysis https://mlllab.atlassian.net/browse/AE-5676 🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AE-5676
NovaSeq X cloud analysis sample sheets referenced the deprecated BCL Convert 4.1.23; this updates them to 4.4.10 with the matching ICA pipeline URN, proven in runs #10165 and #10166.
The i100 local analysis stays on 4.4.6
Only
performAnalysisOnCloud()changed.performAnalysisOnLocalMachine()still writes 4.4.6.V4_1_23 constant kept to avoid a breaking change
Removing it would force a major bump. Consumers that reference the constant directly keep compiling; the default just moved forward.
BCL Convert 4.4 writes CSV reports instead of HTML — left for downstream
The output format change only affects pipelines that parse demux reports, not this library's sample sheet generation.
Rector failure on make it is unrelated
rector/rector2.7.0 removedPHPUnitSetList::PHPUNIT_40referenced inrector.php:12.make stanandmake testpass.Deployment: nemo-api dependency bump follows separately
A follow-up nemo-api MR will bump
mll-lab/php-utilsto the release containing this change. It stays draft until the TWIST EF2.0 validation passes.🤖 Generated with Claude Code