Skip to content

feat(illumina-sample-sheet): use BCL Convert 4.4.10 for NovaSeq X cloud analysis #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fischerl wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(illumina-sample-sheet): use BCL Convert 4.4.10 for NovaSeq X cloud analysis #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/IlluminaSampleSheet/V2/BclConvertSoftwareVersion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class BclConvertSoftwareVersion
{
public const V4_1_23 = '4.1.23';
public const V4_4_6 = '4.4.6';
public const V4_4_10 = '4.4.10';

public string $value;

Expand Down
2 changes: 1 addition & 1 deletion src/IlluminaSampleSheet/V2/Sections/BclConvertSettingsSection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function performAnalysisOn(AnalysisLocation $analysisLocation): void

private function performAnalysisOnCloud(): void
{
$this->keyValues['SoftwareVersion'] = BclConvertSoftwareVersion::V4_1_23;
$this->keyValues['SoftwareVersion'] = BclConvertSoftwareVersion::V4_4_10;
}

private function performAnalysisOnLocalMachine(): void
Expand Down
2 changes: 1 addition & 1 deletion src/IlluminaSampleSheet/V2/Sections/CloudSettingsSection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ final class CloudSettingsSection extends SimpleKeyValueSection
/** @var string */
public const GENERATED_VERSION = '2.6.0.202308300002';
public const CLOUD_WORKFLOW = 'ica_workflow_1';
public const BCL_CONVERT_PIPELINE = 'urn:ilmn:ica:pipeline:d5c7e407-d439-48c8-bce5-b7aec225f6a7#BclConvert_v4_1_23_patch1';
public const BCL_CONVERT_PIPELINE = 'urn:ilmn:ica:pipeline:4bdae602-abe4-4230-b0c6-f886af563b26#BclConvert_v4_4_10';

public function __construct()
{
Expand Down
2 changes: 1 addition & 1 deletion tests/IlluminaSampleSheet/V2/BclConvertSettingsSectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public function testToStringOnCloud(): void
$bclConvertSettingsSection->performAnalysisOn(AnalysisLocation::CLOUD());
$expected = <<<'CSV'
FastqCompressionFormat,gzip
SoftwareVersion,4.1.23
SoftwareVersion,4.4.10

CSV;
self::assertSame($expected, $bclConvertSettingsSection->convertSectionToString());
Expand Down
4 changes: 2 additions & 2 deletions tests/IlluminaSampleSheet/V2/IlluminaSampleSheetVersion2Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function testNovaSeqXCloudSampleSheetToStringReturnsExpectedResult(): voi

[BCLConvert_Settings]
FastqCompressionFormat,gzip
SoftwareVersion,4.1.23
SoftwareVersion,4.4.10

[BCLConvert_Data]
Lane,Sample_ID,Index,Index2,OverrideCycles,AdapterRead1,AdapterRead2,BarcodeMismatchesIndex1,BarcodeMismatchesIndex2
Expand All @@ -140,7 +140,7 @@ public function testNovaSeqXCloudSampleSheetToStringReturnsExpectedResult(): voi
[Cloud_Settings]
GeneratedVersion,2.6.0.202308300002
Cloud_Workflow,ica_workflow_1
BCLConvert_Pipeline,urn:ilmn:ica:pipeline:d5c7e407-d439-48c8-bce5-b7aec225f6a7#BclConvert_v4_1_23_patch1
BCLConvert_Pipeline,urn:ilmn:ica:pipeline:4bdae602-abe4-4230-b0c6-f886af563b26#BclConvert_v4_4_10

[Cloud_Data]
Sample_ID,ProjectName,LibraryName
Expand Down
Loading