Wait for test managers to exit before removing fixtures - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lifecycle tests could delete a fixture directory immediately after receiving a daemon shutdown reply. The daemon was still removing its endpoint, so Linux ARM64 and macOS Intel release jobs failed with
ENOENTduring cleanup after their assertions passed.The fixture now waits for its recorded manager processes to exit before deleting the directory. This changes only test teardown; the memory engine, retrieval logic, and handoff prompt are unchanged.
Validation: the complete lifecycle suite passed locally after the fix. The four-target release build will verify the affected platforms.