Skip to content

Wait for test managers to exit before removing fixtures #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
o8vm merged 1 commit into from
Sep 12, 2026
Merged

Wait for test managers to exit before removing fixtures #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/LifecycleTests.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,22 @@ def withFixture (test : Fixture → IO Unit) : IO Unit := do
try test f
finally
let sessions := root / "data" / "sessions"
let mut managers : List Nat := []
if ← sessions.isDir then
for entry in ← sessions.readDir do
try
let endpoint ← IO.ofExcept (fromJson? (← readObject (entry.path / "daemon.json")) : Except String Daemon.Endpoint)
managers := endpoint.pid :: managers
let _ ← Daemon.exchange endpoint "shutdown" .null
catch _ => pure ()
-- A shutdown reply acknowledges the request before the manager has removed
-- its endpoint and stopped writing. Wait for process exit before traversing
-- the fixture tree; otherwise removeDirAll can race daemon.json removal.
for pid in managers do
awaitCondition (do
let result ← IO.Process.output { cmd := "ps", args := #["-o", "stat=", "-p", toString pid] }
let status := result.stdout.trimAscii.toString
return status.isEmpty || status.startsWith "Z") "fixture manager shutdown"
IO.FS.removeDirAll root

def main (args : List String) : IO UInt32 := do
Expand Down