Repository navigation
Add TOKEN_ENDPOINT/USERINFO_ENDPOINT for mock-relying-party-service - #382
Merged
Merged
Conversation
mock_relying_party_service.TOKEN_ENDPOINT/USERINFO_ENDPOINT only exist as values.yaml defaults in the chart - deployment.yaml's env: block never references them, only ESIGNET_SERVICE_URL/ESIGNET_AUD_URL/ CLIENT_PRIVATE_KEY/JWE_USERINFO_PRIVATE_KEY/USERINFO_RESPONSE_TYPE are hardcoded there. Add via extraEnvVars.*, already the pattern this DSF uses for the chart's other keys. Verified via helm template that both render as real container env vars. ESIGNET_AUD_URL is already present and wired correctly (deployment.yaml does reference mock_relying_party_service.ESIGNET_AUD_URL directly) with per-instance domain-parameterized values, so left unchanged. Signed-off-by: bhumi46 <thisisbn46@gmail.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (16)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
🔗 Linked PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mock_relying_party_service.TOKEN_ENDPOINT/USERINFO_ENDPOINT only exist as values.yaml defaults in the chart - deployment.yaml's env: block never references them, only ESIGNET_SERVICE_URL/ESIGNET_AUD_URL/ CLIENT_PRIVATE_KEY/JWE_USERINFO_PRIVATE_KEY/USERINFO_RESPONSE_TYPE are hardcoded there. Add via extraEnvVars.*, already the pattern this DSF uses for the chart's other keys. Verified via helm template that both render as real container env vars. ESIGNET_AUD_URL is already present and wired correctly (deployment.yaml does reference mock_relying_party_service.ESIGNET_AUD_URL directly) with per-instance domain-parameterized values, so left unchanged.