Repository navigation
For testing: esignet-standalone-2.0.0 testrig docs + apitestrig/uitestrig chart update - #393
Merged
Merged
Conversation
HELMSMAN_TESTRIGS_GUIDE.md was updated for the mosipid1/mosipid2 -> mosipid rename but never gained a row for esignet-standalone-2.0.0, even though helmsman_testrigs.yml's profile dropdown already supports it and Helmsman/dsf/esignet-standalone-2.0.0/testrigs-dsf.yaml deploys the exact same apps into the exact same namespaces (only the hook scripts differ). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1eGZbFM5tT9YS9rcQtwqS Signed-off-by: bhumi46 <thisisbn46@gmail.com>
Replace the generic mosip/apitestrig chart with eSignet's own dedicated mosip/esignet-apitestrig (Go harness) chart, and add mosip/esignet-uitestrig (Java harness) — neither existed in this profile's testrigs-dsf.yaml before, which had just copy-pasted the esignet-standalone (1.0/Java) profile's generic-chart config unmodified. Modeled directly on: https://github.com/mosip/esignet/blob/v2.0.0/deploy/esignet-apitestrig/install.sh https://github.com/mosip/esignet/blob/v2.0.0/deploy/esignet-uitestrig/install.sh - testrigs-dsf.yaml: 3 apitestrig apps (mock/mosipid/sunbird, each in the eSignet instance's own namespace) now use mosip/esignet-apitestrig 2.0.0 with the correct configFile per instance (config.mock/mosip/sunbird.json). 3 new uitestrig apps use mosip/esignet-uitestrig 2.0.0, each in its own namespace (esignet-uitestrig/esignet-mosipid-uitestrig/esignet-sunbird-uitestrig), matching install.sh's own NS/SOURCE_NS split. Only esignet-mosipid (the only instance backed by a real IDA identity) gets real test-identity/onboarding values — esignet-mock and esignet-sunbird need none. - KEYCLOAK_CLIENT_SECRET reuses the existing PMS_CLIENT_SECRET_VALUE convention (same mosip_pms_client_secret key esignet-preinstall-keycloak-init.sh already reads); consent DB password reuses db-common-secrets/db-dbuser-password (same secret helmsman_esignet.yml's own DB-password step reads). Both fetched fresh in new helmsman_testrigs.yml steps since testrigs always run after eSignet DSF has completed. - apitestrig/uitestrig preInstall hooks are now much lighter: the new charts manage their own Secret/ConfigMap from set: values directly, so hooks only need to clean up the old chart's unmanaged CM/secret leftovers (apitestrig) or bootstrap the new namespace (uitestrig) — no more pre-staging secrets. - trigger-test-jobs-esignet.sh now also triggers the 3 new uitestrig namespaces. - helmsman_testrigs.yml: new required Environment secrets/vars for the mosipid-only test identity plus the shared UI-testrig OIDC client, validated up front with a clear error listing what's missing. - docs/HELMSMAN_TESTRIGS_GUIDE.md: documents all of the above — the profile table, the new namespaces, and every new required secret/variable. Report storage uses reports.persistence (PVC) rather than reports.s3 — no established MinIO bucket convention exists yet for these charts in this repo. Signed-off-by: bhumi46 <thisisbn46@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1eGZbFM5tT9YS9rcQtwqS
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (16)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 24, 2026
…H Secrets
10 of the 13 new esignet-standalone-2.0.0 testrig values were GitHub Secrets
even though most are just IDs or test identities (UIN/VID/phone/email), not
actual credentials. Demote everything except the three that are genuinely a
password or client secret down to plain Environment Variables:
stays a Secret: MOSIPID_KEYCLOAK_ADMIN_PASSWORD
ESIGNET_UITESTRIG_CLIENT_SECRET
MOSIPID_TESTRIG_PASSWORD_LOGIN_PASSWORD
now a Variable: MOSIPID_TESTRIG_INDIVIDUAL_ID
MOSIPID_TESTRIG_OTP_RECIPIENT
MOSIPID_TESTRIG_UIN
MOSIPID_TESTRIG_VID
MOSIPID_TESTRIG_PHONE_NUMBER
MOSIPID_TESTRIG_EMAIL_LOGIN_ID
MOSIPID_TESTRIG_PASSWORD_LOGIN_UIN
(AUTH_PARTNER_ID/AUTH_POLICY_ID/OIDC_CLIENT_ID were
already Variables)
Updates helmsman_testrigs.yml's job env: block and validation-step labels,
plus the Required Environment Secrets/Variables table in
docs/HELMSMAN_TESTRIGS_GUIDE.md. testrigs-dsf.yaml itself needs no change —
it references these by name only, not by whether GitHub classifies them as
a secret or a variable.
Signed-off-by: bhumi46 <thisisbn46@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G1eGZbFM5tT9YS9rcQtwqS
Member
|
🔗 Linked PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For testing on
esignetissue2288— continues thees-go-test→esignetissue2288chain (previously merged through #382). Adds the 3 commits since then:esignet-standalone-2.0.0profile inHELMSMAN_TESTRIGS_GUIDE.md(profile table, new namespaces, required secrets).mosip/apitestrig/mosip/uitestrigcharts inesignet-standalone-2.0.0'stestrigs-dsf.yamlwith eSignet's own dedicatedmosip/esignet-apitestrig/mosip/esignet-uitestrigcharts, modeled on eSignet's own reference deploy scripts (apitestrig install.sh, uitestrig install.sh). Adds 3 new uitestrig apps (eSignet itself didn't have UI testrig coverage in this profile before), new required Environment secrets/vars, and updated hooks.MOSIPID_KEYCLOAK_ADMIN_PASSWORD,ESIGNET_UITESTRIG_CLIENT_SECRET,MOSIPID_TESTRIG_PASSWORD_LOGIN_PASSWORD) stay GitHub Secrets — everything else (test IDs/identities) is a plain Variable.docs/HELMSMAN_TESTRIGS_GUIDE.mdupdated to match, with the full secrets/variables table.References
develop: Add esignet-standalone-2.0.0 profile (Go eSignet) support #311🤖 Generated with Claude Code