Repository navigation
For testing: mock-rp-onboarder propertiesOverride + esignet-standalone-2.0.0 testrig deploy fix - #403
Merged
Merged
Conversation
…ck-rp-onboarder first
esignet-mock-rp-onboarder had no onboarding.propertiesOverride.mock-rp-oidc.*
values at all - only generic module/s3/domainConfig config, unlike
esignet-misp-onboarder's own propertiesOverride.esignet.* block. Add the
mock-rp-oidc module's business values (POLICY_NAME, OIDC_CLIENTID,
REDIRECT_URIS, etc.), adapted to this instance with ${domain_name}
substitution in place of the reference's sandbox.mosip.net placeholders.
KEYCLOAK_ADMIN_PASSWORD/KEYCLOAK_CLIENT_SECRET/mosip_pms_client_secret are
deliberately left out of propertiesOverride - putting real credentials in a
committed DSF file would be wrong. They reach the onboarding Job as real
secret env vars instead, via the same extraEnvVarsSecret mechanism
esignet-misp-onboarder already uses - esignet-mock-rp-onboarder-preinstall.sh
already copies both the "keycloak" and "keycloak-client-secrets" secrets into
esignet-mock, but the DSF never actually wired them in via extraEnvVarsSecret
until now.
Also swap priorities so esignet-mock-rp-onboarder (-6) now runs before
esignet-misp-onboarder (-5), reversing the previous order. The two run in
separate namespaces against separate deployments (esignet-mock vs.
esignet-mosipid), so there's no real ordering dependency either way -
comments updated to match.
Signed-off-by: bhumi46 <thisisbn46@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G1eGZbFM5tT9YS9rcQtwqS
…thservices-go-mock Use esignet-go-mock/healthservices-go-mock hostnames for LOGO_URI/REDIRECT_URIS/ EXTERNAL_URL instead of the plain esignet/healthservices ones, and tighten the propertiesOverride block's own explanatory comment. Signed-off-by: bhumi46 <thisisbn46@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1eGZbFM5tT9YS9rcQtwqS
…on gate The hard "Validate esignet-standalone-2.0.0 testrig secrets/variables" step failed the whole helmsman apply whenever any of the 13 new testrig secrets/vars weren't already configured - which none of them were yet, so every 2.0.0 testrig deploy failed outright. Remove that step, and give every one of those values a changeme fallback (matching eSignet's own testrig values.secret.yaml.example placeholder convention) so deployment always succeeds. A changeme deployment still gets a working apitestrig/uitestrig on its normal cron schedule - real values only need to land before an actual test run, updated in the Environment and picked up on the next trigger, no redeploy required. Also remove trigger-test-jobs-esignet.sh for this profile - it was never actually wired as a postInstall hook anywhere in testrigs-dsf.yaml (the only reference to it was the doc's own, incorrect "fires automatically" claim), and there's no need to trigger cronjobs immediately after deploy - they already run on their own configured schedule. docs/HELMSMAN_TESTRIGS_GUIDE.md updated to match: the secrets/variables table now says "Optional" with the changeme-fallback explanation instead of "Required", and the Post-Deployment section no longer claims esignet-standalone-2.0.0 has an auto-trigger step. Signed-off-by: bhumi46 <thisisbn46@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1eGZbFM5tT9YS9rcQtwqS
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (16)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 25, 2026
Match mosip#402 (esqa1-DSD-10860, already merged) exactly instead of diverging on my own placeholder choice: - UPDATE_BEFORE_RUN instead of changeme, everywhere. - MOSIPID_KEYCLOAK_ADMIN_PASSWORD gets no fallback at all - it's already a required, properly-configured secret from the earlier onboarder work, so a fake placeholder there would mask a real config gap instead of papering over an expected-empty one. docs/HELMSMAN_TESTRIGS_GUIDE.md updated to match mosip#402's own wording for the same sections. Signed-off-by: bhumi46 <thisisbn46@gmail.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G1eGZbFM5tT9YS9rcQtwqS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For testing on
esignetissue2288— continues thees-go-test→esignetissue2288chain (previously merged through #393). Adds the 3 commits since then:onboarding.propertiesOverride.mock-rp-oidc.*values foresignet-mock-rp-onboarder(it had none before, unlikeesignet-misp-onboarder), wiresKEYCLOAK_ADMIN_PASSWORD/KEYCLOAK_CLIENT_SECRET/mosip_pms_client_secretin viaextraEnvVarsSecretinstead of hardcoding them, and swaps priorities soesignet-mock-rp-onboardernow runs beforeesignet-misp-onboarder.LOGO_URI/REDIRECT_URIS/EXTERNAL_URLatesignet-go-mock/healthservices-go-mockhostnames. Note: these hostnames aren't provisioned anywhere else in this profile yet (checked — no DNS record, no other DSF reference) — flagged to the requester, kept as specified.esignet-standalone-2.0.0testrigs actually failing to deploy: the "Validate esignet-standalone-2.0.0 testrig secrets/variables" step failed the wholehelmsman applywhenever any of the 13 new testrig secrets/vars weren't configured yet (none were). Removed that gate and gave every one of those values achangemefallback (matching eSignet's own testrigvalues.secret.yaml.exampleconvention) so deployment always succeeds — real values only need to land before an actual test run. Also removedtrigger-test-jobs-esignet.shfor this profile (it was never actually wired as a postInstall hook, and there's no need to trigger cronjobs immediately after deploy).docs/HELMSMAN_TESTRIGS_GUIDE.mdupdated to match.References
develop: Add esignet-standalone-2.0.0 profile (Go eSignet) support #311🤖 Generated with Claude Code