Skip to content

Skipped the linked-issue check for GitHub App bot PRs - #3

Merged
Vpr99 merged 2 commits into
mainfrom
eric/skip-bot-prs-linked-issue
Oct 26, 2026
Merged

Vpr99 merged 2 commits into
mainfrom
eric/skip-bot-prs-linked-issue

Conversation

@Vpr99

@Vpr99 Vpr99 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Fixes WS-1974

  • Bot PRs fail the linked-issue check today. Example: workshop#2988, an autogenerated schema PR from nps-schema-doc-generator[bot].
  • The check now skips a PR when its author has type: "Bot" (GitHub App bots, including Dependabot). This replaces the Dependabot-only login check.
  • Only org admins can install GitHub Apps, so a person cannot use this to skip the check.
  • isBot() lives in .github/scripts/linked-issue.js with tests for Bot and User authors. The key regex is unchanged.
  • README now says that PRs from GitHub App bots pass.

🤖 Generated with Claude Code v2.1.310 (model: Opus 5.5 / claude-opus-5-5)

@Vpr99
Vpr99 requested a review from a team as a code owner October 26, 2026 19:45
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 19be76d6-0131-4371-b7fa-450cf5c3e1cf
Commits

Reviewing files that changed from the base of the PR and between e77aa99 and 8cdb8b8.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: ab8f5d7c-a019-4004-a064-5c945207101d
Commits

Reviewing files that changed from the base of the PR and between 302601b and e77aa99.

Files selected for processing: 4
  • .github/scripts/linked-issue.js
  • .github/scripts/linked-issue.test.js
  • .github/workflows/linked-issue.yml
  • README.md

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

Walkthrough

The linked-issue workflow now identifies bot authors by user type instead of checking for the Dependabot login. Tests cover bot and non-bot classification, and the README describes the updated behavior.

Changes: Bot-aware linked-issue checks

Layer / File(s) Summary
Bot identification and workflow
.github/scripts/linked-issue.js, .github/workflows/linked-issue.yml, .github/scripts/linked-issue.test.js, README.md
The script exports isBot, which checks whether a user's type is Bot. The workflow uses this helper for pull request authors. Tests cover Dependabot, an app bot, and a user. The README states that GitHub App bots pass.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · previous review e77aa

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 2
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: skipping the linked-issue check for GitHub App bot pull requests.
Description check Passed The description states the problem (bot PRs fail the linked-issue check), names the example PR, and explains the fix: skipping PRs whose author has type "Bot" and replacing the Dependabot-only login c…
Full details: Description check

Explanation

The description states the problem (bot PRs fail the linked-issue check), names the example PR, and explains the fix: skipping PRs whose author has type "Bot" and replacing the Dependabot-only login check. It also covers the isBot() helper, its tests, the unchanged key regex, and the README update. This matches the changeset and the PR objectives, so the check passes.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Vpr99
Vpr99 merged commit 972ce8d into main Oct 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants