fix(shell): align omarchy toggle bar semantics so on shows and off hides - #11894
Open
szaidi-code wants to merge 1 commit into
Open
szaidi-code wants to merge 1 commit into
szaidi-code wants to merge 1 commit into
Conversation
Fixes omacom#11817 omarchy-toggle bar-off previously received on/off directly, which caused 'omarchy toggle bar on' to set the bar-off toggle (hiding the bar) and 'omarchy toggle bar off' to remove it (showing the bar). Invert the on/off action passed to the underlying bar-off toggle so that 'on' makes the bar visible and 'off' hides it. Update omarchy-toggle-fullscreen-desktop and test assertions accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11817
Description
Currently,
omarchy-toggle bar-offforwards the caller's argument directly to the underlying toggle file (bar-off). Because the toggle represents the off state (presence of~/.local/state/omarchy/toggles/bar-offhides the bar), calling:omarchy toggle bar onactivated thebar-offtoggle, thereby hiding the bar.omarchy toggle bar offremoved thebar-offtoggle, thereby showing the bar.This is inverted from the command's documented semantics and user intent.
Changes
bin/omarchy-toggle-bar, mapon->offandoff->onwhen forwarding toomarchy-toggle bar-off.toggleremains unchanged.bin/omarchy-toggle-fullscreen-desktopto callomarchy-toggle-bar offwhen entering full screen andomarchy-toggle-bar onwhen leaving full screen.test/shell.d/toggle-test.shandtest/acceptance.d/session-test.shto verify thatbar onclearsbar-offandbar offsetsbar-off.Verification
bash test/shell.d/toggle-test.shon host and inside Arch Linux container (CT 201) — all 13 checks passed../test/cli— 100% pass.