Skip to content

fix: secure runtimes and keep cancelled threads closed - #308

Merged
steipete merged 4 commits into
mainfrom
security/workerd-denylist-20261026
Oct 26, 2026
Merged

steipete merged 4 commits into
mainfrom
security/workerd-denylist-20261026

Conversation

@joshavant

@joshavant joshavant commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Local Worker execution previously accepted compromised certificate chains when historical roots were explicitly supplied. Pin workerd to 1.20261021.1 and keep its native runtime selected by both Wrangler and Miniflare. The original native TLS evidence covers incident-chain rejection and legitimate public/private-CA controls; this follow-up retains the same macOS ARM64 binary SHA-256, 44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64. This establishes local runtime behavior, not deployed Cloudflare fleet delivery.

A browser CI failure also exposed a navigation race: Escape could close a search-opened thread while an unfinished navigation later reopened it. The follow-up tracks pending app navigation so returning to the still-visible channel URL cancels that transition. A deterministic regression fails with the old guard and passes with the fix; the failed browser scenario and live Chrome check pass.

The maintenance pass also patches vulnerable transitive URI parsing, brace expansion, HTTP caching, and Undici packages. SvelteKit 3 with adapter 4 removes its two remaining advisories; the static SPA configuration moves to Vite, internal library imports use package subpaths, and the notification worker retains a separate typecheck. SQLite 1.61.0 and its required libc 1.79.0 move together. Wrangler, virtual scrolling, and desktop packaging receive compatible updates. The Go 1.26.6 module minimum, Go 1.27.3 toolchain, Node 24 minimum, and 48-hour package release-age policy remain in place.

Validation:

  • Frozen pnpm installation and supply-chain policy pass; npm audit falls from 19 findings to zero.
  • Full repository gate stages pass locally with nice -n 19, compiler/test concurrency capped at two: web and Go tests, FakeCo AWS and desktop contract tests, root/workspace and worker typechecks, lint, formatting, web/SDK/embedded/desktop builds, and docs build.
  • govulncheck ./... reports no reachable or imported-package vulnerabilities. Its module-only notice is GO-2026-5932 in the unused golang.org/x/crypto/openpgp package, with no upstream fix; ClickClack does not import that package.
  • Independent P0–P2 review completed the full maintenance diff and the navigation follow-up with no actionable findings. Exact-head CI must pass before merge and covers PostgreSQL, browser behavior, Docker, Node 24 compatibility, and macOS/Windows/Linux packaging.

No application version bump, release, tag, or manual deployment is included.

Co-authored-by: joshavant 830519+joshavant@users.noreply.github.com

@joshavant
joshavant requested a review from a team as a code owner October 26, 2026 09:20
@clawsweeper

clawsweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 26, 2026
@clawsweeper

clawsweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR pins workerd and its platform binaries to 1.20261021.1 while retaining Wrangler and Miniflare versions.

Example: A local Worker fetches https://dv-g3b-emudhra.we-have-a-problem.com/ with historical roots explicitly trusted.

  • Before: workerd 1.20261012.1 accepts the chain and receives HTTP 200.
  • After: workerd 1.20261021.1 rejects the TLS handshake with CertDistrusted; legitimate public and private-CA HTTPS still succeeds.

Review scores

Measure Result What it means
Overall readiness 🦞 diamond lobster (5/6) A minimal dependency repair with inspectable native network evidence, matching consumer artifacts, and no open findings.
Proof confidence 🦞 diamond lobster (5/6) Sufficient (logs): The full consumer supplement and linked exact-binary traces resolve the earlier attachment gap: frozen resolution selects the matching macOS ARM64 executable, real workerd serve runs Worker fetches, all 14 incident chains fail TLS verification in both trust modes, and public/private-CA controls succeed; local bundle startup is separately recorded, while wire-byte counts, resumed sessions, other architectures, containers, and managed-fleet delivery remain outside the demonstrated claim.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: Local Worker execution accepts incident certificate chains when historical roots are explicitly supplied.
Reason: The maintainer-authored direction repairs a demonstrated trust failure through the existing dependency owner.

Merge readiness

✅ Ready for maintainer review

This PR remains necessary because main still selects the older workerd; the focused dependency update has no actionable findings.

Priority: P2
Reviewed head: fb6f30be66f373dc904f443b016456fd37c11aee

Before merge

None.

Findings

None.

Agent review details

How this fits together

pnpm resolves the native workerd used by Wrangler and Miniflare for local Worker execution, including outbound HTTPS certificate verification.

flowchart LR
  A[pnpm override] --> B[Frozen dependency graph]
  B --> C[Wrangler and Miniflare]
  C --> D[Native workerd]
  D --> E[TLS certificate verification]
  E --> F[Trusted HTTPS response or handshake rejection]
Loading

Technical review

Best possible solution:

Land the focused runtime pin with the published local TLS evidence and its stated deployment limits.

Do we have a high-confidence way to reproduce the issue?

Published native macOS ARM64 output shows the exact main-baseline binary accepting all 14 incident chains in both historical-trust modes.

Is this the best way to solve the issue?

The existing pnpm override mechanism is the smallest complete consumer fix and avoids parallel application-level trust logic.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against ba5b9e5e497f.

Provenance checked

  • Wrangler/Miniflare workerd resolution changes intended behavior with a stated reason (112d076: The merged tooling refresh selected the existing Wrangler and transitive runtime versions; its stated SQLite pairing requirement concerns a separate dependency boundary.)
  • Workspace security overrides and release-age policy keeps the original intent (chore(deps): refresh Svelte tooling and audit fixes #158: Security fixes use workspace-owned overrides and a regenerated lockfile while retaining the package release-age policy.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Likely related people:

  • Josh Avant: Raw commit 293f479 adds pnpm-lock.yaml:10 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 293f47908124; files: pnpm-lock.yaml)

Labels

Label changes:

  • add proof: sufficient: Contributor real behavior proof is sufficient.
  • add rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • remove rating: 🧂 unranked krab: Current PR rating is rating: 🦞 diamond lobster, so this older rating label is no longer current.
  • remove status: 📣 needs proof: Current PR status label is status: 👀 ready for maintainer look.

Label justifications:

  • P2: This is a concrete security repair for local development/test execution with limited delivery scope.
  • merge-risk: 🚨 security-boundary: The runtime changes outbound certificate acceptance; the maintainer-directed rejection is supported by native incident and legitimate-peer controls.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • proof: sufficient: Contributor real behavior proof is sufficient.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (1 earlier review cycle)
  • reviewed 2026-10-26T09:34:47.925Z sha fb6f30b :: needs real behavior proof before merge. :: none

Reviewed October 26, 2026, 5:50 AM ET / 09:50 UTC (Revision 2).

@joshavant

Copy link
Copy Markdown
Contributor Author

Native TLS proof supplement for final source fb6f30be66f373dc904f443b016456fd37c11aee; no source changes or new test runs.

This addresses the actual review by publishing retained native macOS ARM64 output. The shared candidate proof contains the complete exact-candidate 32-row matrix, all 14 successful independent chain+exact-hostname controls with DER/SPKI identities, both complete native rejection logs with matched error references, the executed fixture Worker/harness, historical-root hash, and public/private-CA positive controls. That is the same native candidate binary selected by this repository: SHA256 44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64. The exact consumer resolver and baseline evidence are attached below; reusing the candidate run does not infer one repository's bundle behavior from another.

Source head fb6f30be66f373dc904f443b016456fd37c11aee, base ba5b9e5e497f8c5d6cf248e4ff6f69a9dfd2e2f5. Workerd 1.20261012.1 → 1.20261021.1; Wrangler/Miniflare versions are retained. Native Darwin 27.0.0 ARM64 guest, Node 26.12.1; repository-owned package manager and frozen installs are recorded below. No OS trust was changed.

Native engine Explicit-only historical trust Platform plus historical trust Legitimate public/private-CA HTTPS
Actual frozen baseline 1.20261012.1 14/14 incident chains accepted 14/14 incident chains accepted 2/2 succeed in each mode
Exact selected candidate 1.20261021.1 14/14 rejected (OtherError(CertDistrusted)) 14/14 rejected (Revoked) 2/2 succeed in each mode

Historical CA SHA256 c3aa6ce83618c247fdeb0afad3a4eb1d01da2eb9035defe70f74c4bbaaca986f plus a generated private fixture CA were supplied identically. Explicit-only uses trustBrowserCas=false; platform-plus-explicit uses true. All 14 incident endpoints had successful independent exact-hostname/chain controls and include alternate/cross-signed certificates sharing six verified incident TLS SPKIs. The two code-signing keys have source-denylist evidence, not live code-signing execution.

Observed boundary and limitation: The exact candidate's raw errors say TLS handshake failed: invalid peer certificate; Worker await fetch() throws before producing a response. The shared proof links the pinned native TLS handshake/configuration owners. This establishes verifier rejection during handshake and before Worker response acceptance. The retained campaign did not measure remote application bytes, capture packets/TLS keys, obtain incident-peer request logs, or qualify resumed-session/0-RTT behavior. A literal universal zero-application-bytes/zero-credentials-on-the-wire result remains unverified, and is not inferred from an HTTP500 or from a failed connection.

The standalone fixture Worker exercises the actual installed native executable's outbound-fetch boundary; application bundle build/startup and owning gates below are separate evidence. This proves local development/test runtime adoption within macOS ARM64; it does not establish Cloudflare managed-fleet delivery, production deployment, other architectures or unrelated application features.

Owning local full-JavaScript build/tests/typechecks and supported Worker-only dry-run passed. Default dry-run requires a container build and failed setup because the task guest had no Docker; supported --containers-rollout=none dry-run and --enable-containers=false local startup passed. No host Docker was used. This lane does not claim container/native desktop qualification.

Exact source/native artifacts and installed resolver
{
  "head": "fb6f30be66f373dc904f443b016456fd37c11aee",
  "base": "ba5b9e5e497f8c5d6cf248e4ff6f69a9dfd2e2f5",
  "patchSha256": "e526c43788d1f22c9f20dc90ab8b5ddf4e867044e4768b33d34223002966889e",
  "sourceFiles": [
    {
      "path": "pnpm-lock.yaml",
      "sha256": "c948d9485d0cc50800a3e4984b2b64c14228908c18b463cb48c93c7291d467ff"
    },
    {
      "path": "pnpm-workspace.yaml",
      "sha256": "34510652b69b50c7f85f0760d95f493cb6feead1cd7ec96efed8b138a962c322"
    }
  ],
  "nativeArtifacts": [
    {
      "label": "clickclack-baseline",
      "path": "<TASKROOT>/native-engine/baseline-clickclack/workerd",
      "sha256": "2449d1a1404e54b832fd3265fd61803072438bf7559b7b28d491fd5f24a627bf",
      "version": "workerd 2026-10-12"
    },
    {
      "label": "candidate",
      "path": "<TASKROOT>/native-engine/1.20261021.1/workerd",
      "sha256": "44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64",
      "version": "workerd 2026-10-21",
      "npmIntegrity": "sha512-OZ6Qkc9EwNl6kOyEBBQIOmOsbIfWCeR7F6h0EcScdjQLIB6drsmSpEZuBC3gAgz/eqDqjDrDCbPAA7jDllxIMw==",
      "tarballSha256": "0ffe5070b2494dad46121253e9268115bc94b37a69eb7283d3a05f5439c1ba06",
      "metadataSha256": "a4e17e123709b78c21ff04a106c42acea0314259262f1e19d8f642e5f76e3d4e"
    }
  ],
  "installedResolver": {
    "wrangler": "4.151.1",
    "miniflareEntry": "<TASKROOT>/clickclack/repo/node_modules/.pnpm/miniflare@5.20261012.1-beta_@types+node@26.6.5/node_modules/miniflare/dist/src/index.js",
    "workerdExecutable": "<TASKROOT>/clickclack/repo/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261021.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
    "sha256": "44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64"
  }
}
All 32 retained baseline result rows (both trust modes, incident and legitimate controls)
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://example.com/","startedUtc":"2026-10-26T09:06:43.426217+00:00","result":{"ok":true,"status":200,"body":"<!doctype html><html lang=en><head><meta charset=utf-8><link rel=icon href=data:,><meta name=viewport content=\"width=dev"},"elapsedSeconds":0.05}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://localhost:19889/","startedUtc":"2026-10-26T09:06:43.476215+00:00","result":{"ok":true,"status":200,"body":"workerd-native-mac-private-positive"},"elapsedSeconds":0.004}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://dv-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:43.480578+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://dv-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:43.653246+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.173}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ov-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:43.826340+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ov-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:43.998208+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ev-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:44.170774+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.169}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ev-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:44.340072+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://dv-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:44.512425+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://dv-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:44.683617+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ov-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:44.854945+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ov-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:45.026410+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ev-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:45.197777+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.173}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://ev-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:45.371001+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://dv-g3b-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:45.543330+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.548}
{"engine":"clickclack-baseline","mode":"explicit-only","url":"https://dv-g3b-aaa-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:46.091642+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.547}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://example.com/","startedUtc":"2026-10-26T09:06:46.762753+00:00","result":{"ok":true,"status":200,"body":"<!doctype html><html lang=en><head><meta charset=utf-8><link rel=icon href=data:,><meta name=viewport content=\"width=dev"},"elapsedSeconds":0.037}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://localhost:19889/","startedUtc":"2026-10-26T09:06:46.800637+00:00","result":{"ok":true,"status":200,"body":"workerd-native-mac-private-positive"},"elapsedSeconds":0.004}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:46.804787+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.173}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://dv-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:46.978262+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ov-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:47.150117+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ov-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:47.321606+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ev-g3b-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:47.493641+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ev-g3c-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:47.666610+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:47.839028+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.17}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://dv-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:48.009763+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ov-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:48.182253+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.172}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ov-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:48.354671+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.169}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ev-g3b-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:48.523926+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://ev-g3c-aaa-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:48.695266+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.171}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:48.866512+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.542}
{"engine":"clickclack-baseline","mode":"system-plus-explicit","url":"https://dv-g3b-aaa-noct-emudhra.we-have-a-problem.com/","startedUtc":"2026-10-26T09:06:49.409277+00:00","result":{"ok":true,"status":200,"body":"Your client successfully connected to the site. That's bad!\n"},"elapsedSeconds":0.542}
Actual frozen baseline install
{
  "repo": "clickclack",
  "stage": "baseline-install",
  "command": [
    "pnpm",
    "install",
    "--frozen-lockfile",
    "--store-dir",
    "<TASKROOT>/clickclack/pnpm-store"
  ],
  "exitCode": 0,
  "elapsedSeconds": 7.888,
  "runtime": "v26.12.1",
  "bun": "1.4.4",
  "packageRoot": "<TASKROOT>/clickclack/repo",
  "artifacts": [
    {
      "path": "<TASKROOT>/clickclack/repo/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261012.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
      "sha256": "2449d1a1404e54b832fd3265fd61803072438bf7559b7b28d491fd5f24a627bf",
      "version": "workerd 2026-10-12"
    }
  ],
  "recordedUtc": "2026-10-26T09:04:34.783250+00:00"
}
Candidate install and exact resolution
{
  "repo": "clickclack",
  "commands": [
    {
      "command": [
        "pnpm",
        "install",
        "--lockfile-only",
        "--ignore-scripts",
        "--store-dir",
        "<TASKROOT>/clickclack/pnpm-store"
      ],
      "exitCode": 0,
      "elapsedSeconds": 2.94
    },
    {
      "command": [
        "pnpm",
        "install",
        "--frozen-lockfile",
        "--store-dir",
        "<TASKROOT>/clickclack/pnpm-store"
      ],
      "exitCode": 0,
      "elapsedSeconds": 3.106
    }
  ],
  "artifacts": [
    {
      "path": "<TASKROOT>/clickclack/repo/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261021.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
      "sha256": "44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64",
      "version": "workerd 2026-10-21"
    },
    {
      "path": "<TASKROOT>/clickclack/repo/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261012.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd",
      "sha256": "2449d1a1404e54b832fd3265fd61803072438bf7559b7b28d491fd5f24a627bf",
      "version": "workerd 2026-10-12"
    }
  ],
  "identityExit": 0,
  "identity": "{\"wrangler\":\"4.151.1\",\"miniflareEntry\":\"<TASKROOT>/clickclack/repo/node_modules/.pnpm/miniflare@5.20261012.1-beta_@types+node@26.6.5/node_modules/miniflare/dist/src/index.js\",\"workerdExecutable\":\"<TASKROOT>/clickclack/repo/node_modules/.pnpm/@cloudflare+workerd-darwin-arm64@1.20261021.1/node_modules/@cloudflare/workerd-darwin-arm64/bin/workerd\",\"sha256\":\"44a06c31a6578f234cdf7f23219b88978c8d8d21cb8ce85795cab53614b50d64\"}\n",
  "recordedUtc": "2026-10-26T09:09:55.653739+00:00",
  "lockSha256": "c948d9485d0cc50800a3e4984b2b64c14228908c18b463cb48c93c7291d467ff"
}
Owning validation commands and actual exit results
[
  {
    "command": [
      "pnpm",
      "fmt:ts:check"
    ],
    "label": "format",
    "exitCode": 0,
    "elapsedSeconds": 1.468
  },
  {
    "command": [
      "pnpm",
      "lint"
    ],
    "label": "lint",
    "exitCode": 0,
    "elapsedSeconds": 0.344
  },
  {
    "command": [
      "pnpm",
      "--filter",
      "@clickclack/web",
      "test"
    ],
    "label": "web-tests",
    "exitCode": 0,
    "elapsedSeconds": 0.557
  },
  {
    "command": [
      "pnpm",
      "typecheck"
    ],
    "label": "typecheck",
    "exitCode": 0,
    "elapsedSeconds": 0.871
  },
  {
    "command": [
      "pnpm",
      "-r",
      "typecheck"
    ],
    "label": "workspace-typecheck",
    "exitCode": 0,
    "elapsedSeconds": 1.43
  },
  {
    "command": [
      "pnpm",
      "build"
    ],
    "label": "build",
    "exitCode": 0,
    "elapsedSeconds": 3.826
  },
  {
    "label": "dry-run",
    "command": [
      "wrangler",
      "deploy",
      "--dry-run",
      "--outdir",
      "<TASKROOT>/clickclack/rebuilt-worker"
    ],
    "exitCode": 1,
    "elapsedSeconds": 0.813
  }
]
Actual local product startup/result
{
  "repo": "clickclack",
  "stage": "candidate",
  "command": [
    "wrangler",
    "dev",
    "--local",
    "--ip",
    "127.0.0.1",
    "--port",
    "19925",
    "--inspector-port",
    "19926",
    "--persist-to",
    "<TASKROOT>/clickclack/state/candidate",
    "--enable-containers=false"
  ],
  "startedUtc": "2026-10-26T09:14:35.504569+00:00",
  "requests": [],
  "ready": true,
  "processExitBeforeCleanup": null,
  "taskProcessGroupStopped": true
}
Supported Worker-only dry-run
{
  "command": [
    "wrangler",
    "deploy",
    "--dry-run",
    "--containers-rollout=none",
    "--outdir",
    "<TASKROOT>/clickclack/rebuilt-worker-no-containers"
  ],
  "exitCode": 0,
  "scope": "supported Worker-only bundle; container image deliberately not built"
}
Recorded rebuilt bundle identities (empty means no emitted artifact was retained)
[
  {
    "path": "rebuilt-worker-no-containers/README.md",
    "sha256": "4d013797e6f642fca5908f93ca5e27c0b65163cd034e3c0f55d127a28959e8a6",
    "bytes": 111
  },
  {
    "path": "rebuilt-worker-no-containers/worker.js",
    "sha256": "2d690c2aae14d0838a0d3818193bf63df6e18e93b033f035c45fdaeda3f7a4d1",
    "bytes": 56285
  },
  {
    "path": "rebuilt-worker-no-containers/worker.js.map",
    "sha256": "91700cb864b7ee353288d3765151e97e9fd4af434ccced389bd590cb5b5790e1",
    "bytes": 26529
  }
]
Original retained input and redacted projection hashes
[
  {
    "path": "collected/clickclack/evidence/candidate-selected-identity.log",
    "sha256": "864e4c6f60edb81ff9d5860b92dd6aac77d98f434385ba0dc3c182df500e33e1",
    "projection": "candidate-selected-identity.json",
    "projectionSha256": "e85aa62e656c9fe3a8611a15456858d37909596dd63c1edbd75cf2f80957eb94",
    "redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
  },
  {
    "path": "collected/clickclack/evidence/baseline-install.json",
    "sha256": "d4f015f22a5712da213fd518b41c4eda5b4053d482442c0d49212c137f5d05d1",
    "projection": "baseline-install.json",
    "projectionSha256": "c8b1a59ecc2d23bc7a440453602e938d7baad7b5d6dec7372bb349c5fdf06447",
    "redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
  },
  {
    "path": "collected/clickclack/evidence/candidate-install.json",
    "sha256": "4a35b485f61d63f03f1af6e16ac1f162751bd493f61e1c8d71e84078cf21f2cf",
    "projection": "candidate-install.json",
    "projectionSha256": "43b377902eac940d027201d07543fc9605c98457420950ac46b7edc2ff13a130",
    "redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
  },
  {
    "path": "collected/clickclack/evidence/candidate-checks.json",
    "sha256": "f6b94bc9dbd1fc04eb76c7e1e8acddfadb64ca43f0b46207f73bf56d95a86f45",
    "projection": "candidate-checks.json",
    "projectionSha256": "0e814aaed0b80283a7bcc5fbff60c06246e8eccafeb7180929cb713c18120924",
    "redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
  },
  {
    "path": "collected/clickclack/evidence/candidate-local-worker.json",
    "sha256": "9192618a7c1e4453789730d70913f8a6b50a6c87910e5806f0e59c667829eb66",
    "projection": "candidate-local-worker.json",
    "projectionSha256": "46050b116fdfd8744265f5fdc4243741943d80ce50853d867bb961952dea9e1b",
    "redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
  },
  {
    "path": "collected/clickclack/evidence/candidate-worker-only-dryrun.json",
    "sha256": "ed8324b9c49a8457e2317a88b1bdcf04e02ef437f037d2565c350afe1665e591",
    "projection": "candidate-worker-only-dryrun.json",
    "projectionSha256": "869105795bff1a3059436bdf68b411f586c70188f5ecdd40bcceca6ab64b4845",
    "redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
  },
  {
    "path": "collected/clickclack/evidence/rebuilt-worker-only-artifacts.json",
    "sha256": "05455931c457a8d6c32fbb61116693ed30d0b22933ee62e119768dcd2f1745a7",
    "projection": "rebuilt-worker-only-artifacts.json",
    "projectionSha256": "05455931c457a8d6c32fbb61116693ed30d0b22933ee62e119768dcd2f1745a7",
    "redactions": "Task-root/tool paths and explicitly synthetic secret markers only"
  },
  {
    "path": "collected/native-engine/evidence/results.json",
    "sha256": "0c6f25ddb0abcdbc14c60f4839777f85baf043301453d6711172503fbc4b1d39",
    "publicScope": "Lossless field-preserving selection of this consumer baseline32rows; exact candidate32rows in linked shared proof"
  }
]

@joshavant

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 26, 2026
KrasimirKralev and others added 2 commits October 26, 2026 03:32
Correct the agent-friendly CLI guide to match the shared message-body resolver: nonblank --body, then --file, then --stdin, then positional text. This preserves existing script behavior and documents whitespace-only --body fallback.

Validated the guide against the send and threads reply call sites and resolveBody implementation. The docs site builds locally; independent scoped review found no actionable P0–P2 findings. Exact-head CI passed Go, TypeScript, Node 24 compatibility, Playwright, Docker, and desktop builds on macOS, Windows, and Linux.

Co-authored-by: Krasimir Kralev <263465593+KrasimirKralev@users.noreply.github.com>
Pin the patched local Worker engine, refresh vulnerable transitive dependencies,
and update SQLite with its matching libc runtime. Migrate the static web build
to SvelteKit 3 while retaining manual push registration and separate worker
checking. Preserve the existing Go and Node minimums and release-age policy.

Co-authored-by: joshavant <830519+joshavant@users.noreply.github.com>
@steipete steipete changed the title fix(security): adopt patched workerd certificate rejection build(deps): patch runtimes and update web tooling Oct 26, 2026
A current-URL shortcut could skip the navigation that cancels a pending
search-to-thread transition. Track outstanding navigation so Escape can return
to the visible channel before that transition commits. Preserve idle same-path
no-ops and release pending state after resolution or rejection.

Add a deterministic regression, update the search guide, and rebuild embedded
assets. The failed browser scenario passes locally with the fix.
@steipete steipete changed the title build(deps): patch runtimes and update web tooling fix: secure runtimes and keep cancelled threads closed Oct 26, 2026
@steipete

Copy link
Copy Markdown
Contributor

The first updated CI run passed 435 browser tests and exposed one timing-sensitive failure: Escape could close a search-opened thread, then an in-flight navigation reopened it. The current-URL optimization returned before cancelling that pending navigation.

The follow-up tracks pending app navigation and still asks the router to return to the channel when its URL is already visible. A deterministic regression fails with the original guard and passes with the fix, including cleanup after navigation rejection. The failed chat scenario passes locally with one browser worker. Live Chrome also confirms the thread closes and the URL returns to the channel.

Screenshots show the fixed build’s search-opened thread before Escape and the returned channel afterward, using only synthetic Local Captain data.

Before Escape: synthetic search result open in its thread

After Escape: returned to the channel with the thread closed

@steipete

Copy link
Copy Markdown
Contributor

Final candidate: 8c99111. Independent review is clean, the navigation regression and targeted browser scenario pass locally, and the current head passes Go, TypeScript, Node 24 compatibility, Playwright, Docker, CodeQL, and Windows/Linux packaging.

The macOS Desktop job remains queued for xcode-27: https://github.com/openclaw/clickclack/actions/runs/40313565869/job/121540451987. The bounded CI polling budget is exhausted, so this stays open pending that proof. No source revision is requested.

CI: https://github.com/openclaw/clickclack/actions/runs/40313565935
Synthetic live browser proof: #308 (comment)

@steipete
steipete merged commit 541ce93 into main Oct 26, 2026
14 of 15 checks passed
@steipete
steipete deleted the security/workerd-denylist-20261026 branch October 26, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 security-boundary 🚨 Merging this PR could weaken sandboxing, authorization, credentials, or sensitive data. P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants